Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2660543003: [turbofan] for-in only enumerates Strings. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] for-in only enumerates Strings. Update type of JSForInNext to say String\/Undefined. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2660543003 Cr-Commit-Position: refs/heads/master@{#42768} Committed: https://chromium.googlesource.com/v8/v8/+/2c51ca8fa31c7d2cc41ced34729c8cdc6e3063e7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Benedikt Meurer
3 years, 10 months ago (2017-01-27 12:42:36 UTC) #1
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-30 10:52:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660543003/1
3 years, 10 months ago (2017-01-30 10:52:52 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 11:23:27 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2c51ca8fa31c7d2cc41ced34729c8cdc6e3...

Powered by Google App Engine
This is Rietveld 408576698