chrome/browser/favicon/favicon_handler.h - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/favicon/favicon_handler.h

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Merge with Avi's change Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/favicon/favicon_handler.h

diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h

index 7dc6a7fbeee64420c46fd57e2948ad58690a3944..6cb9d5913a8ea1ae610873071b76f1c0e43d0db0 100644

--- a/chrome/browser/favicon/favicon_handler.h

+++ b/chrome/browser/favicon/favicon_handler.h

@@ -97,8 +97,7 @@ class FaviconHandler {

// Message Handler. Must be public, because also called from

// PrerenderContents. Collects the |image_urls| list.

- void OnUpdateFaviconURL(int32 page_id,

- const std::vector<content::FaviconURL>& candidates);

+ void OnUpdateFaviconURL(const std::vector<content::FaviconURL>& candidates);

// Processes the current image_irls_ entry, requesting the image from the

// history / download service.

« no previous file with comments | « chrome/browser/extensions/favicon_downloader_unittest.cc ('k') | chrome/browser/favicon/favicon_handler.cc » ('j') | no next file with comments »