chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc - Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/favicon/favicon_tab_helper.cc ('k') | chrome/browser/ui/ash/launcher/launcher_favicon_loader_browsertest.cc » ('j') | content/browser/web_contents/web_contents_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

diff --git a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

index d1fc9536ca8efd831f0c3940d6022267e502f71a..e6c84bb6a4e46ab53486e8b2dbff0c780e77b2c1 100644

--- a/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

+++ b/chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc

@@ -41,7 +41,6 @@ class FaviconBitmapHandler : public content::WebContentsObserver {

// content::WebContentObserver implementation.

virtual void DidUpdateFaviconURL(

- int32 page_id,

const std::vector<content::FaviconURL>& candidates) OVERRIDE;

private:

@@ -73,7 +72,6 @@ class FaviconBitmapHandler : public content::WebContentsObserver {

};

void FaviconBitmapHandler::DidUpdateFaviconURL(

- int32 page_id,

const std::vector<content::FaviconURL>& candidates) {

// This function receives a complete list of faviocn urls for the page.

// It may get called multiple times with the same list, and will also get