Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6771)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 266053003: Remove page IDs from three WebContentsObserver APIs that don't need it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_tab_helper.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc
index 542c634073cbf2b77e6bdadf792f9a5a0ddae344..a6a7bb84c9411a7ebe413518e51eaf73fca916f9 100644
--- a/chrome/browser/favicon/favicon_tab_helper.cc
+++ b/chrome/browser/favicon/favicon_tab_helper.cc
@@ -191,14 +191,13 @@ void FaviconTabHelper::DidNavigateMainFrame(
}
void FaviconTabHelper::DidUpdateFaviconURL(
- int32 page_id,
const std::vector<content::FaviconURL>& candidates) {
DCHECK(!candidates.empty());
favicon_urls_ = candidates;
- favicon_handler_->OnUpdateFaviconURL(page_id, candidates);
+ favicon_handler_->OnUpdateFaviconURL(candidates);
if (touch_icon_handler_.get())
- touch_icon_handler_->OnUpdateFaviconURL(page_id, candidates);
+ touch_icon_handler_->OnUpdateFaviconURL(candidates);
}
FaviconService* FaviconTabHelper::GetFaviconService() {

Powered by Google App Engine
This is Rietveld 408576698