Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2660423004: Rename EOverflow values with k prefix. (Closed)

Created:
3 years, 10 months ago by shend
Modified:
3 years, 10 months ago
Reviewers:
nainar, sashab
CC:
darktears, apavlov+blink_chromium.org, atotic+reviews_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, cbiesinger, chromium-reviews, dglazkov+blink, dgrogan+ng_chromium.org, dshwang, krit, eae+blinkwatch, f(malita), fs, glebl+reviews_chromium.org, gyuyoung2, jchaffraix+rendering, jfernandez, kouhei+svg_chromium.org, leviw+renderwatch, ojan+watch_chromium.org, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, Manuel Rego, rwlbuis, Stephen Chennney, sof, svillar, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename EOverflow values with k prefix. Rename the values of the EOverflow enum with the k prefix to match the style generated by make_computed_style_base.py, which is in line with the Blink rename to match Chromium style. This also prefixes PagedX and PagedY with Webkit since they are webkit specific keywords. This is prework for generating EOverflow. BUG=684966 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2660423004 Cr-Commit-Position: refs/heads/master@{#447711} Committed: https://chromium.googlesource.com/chromium/src/+/bb83e4dea76b261e101277f39a0703a0e5ae98d7

Patch Set 1 #

Patch Set 2 : Add webkit prefix #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -118 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 1 2 2 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp View 5 chunks +28 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/GridTrackSizingAlgorithm.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.h View 1 2 chunks +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControl.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/TextAutosizer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGRoot.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGLayoutSupport.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/SpatialNavigation.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 2 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
shend
Hi Naina, more renames PTAL :)
3 years, 10 months ago (2017-02-01 00:54:20 UTC) #4
nainar
lgtm
3 years, 10 months ago (2017-02-01 00:59:10 UTC) #6
shend
Hey Sasha, more renames PTAL :)
3 years, 10 months ago (2017-02-01 01:51:05 UTC) #8
sashab
lgtm
3 years, 10 months ago (2017-02-01 18:16:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660423004/40001
3 years, 10 months ago (2017-02-02 03:28:51 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 06:40:32 UTC) #19
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/bb83e4dea76b261e101277f39a07...

Powered by Google App Engine
This is Rietveld 408576698