Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: content/public/browser/navigation_handle.h

Issue 2660403006: Convert RenderViewHostTest to use the new navigation callbacks. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_view_host_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index 153be328985bbcec83b244a096998778cc72d4a5..b329165aa12b0a0794283dbc02db032e4dca9d7d 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -11,7 +11,8 @@
#include "content/common/content_export.h"
#include "content/public/browser/navigation_throttle.h"
#include "content/public/browser/reload_type.h"
-#include "content/public/common/referrer.h"
+#include "content/public/common/referrer.h"
+#include "net/base/host_port_pair.h"
#include "net/base/net_errors.h"
#include "net/http/http_response_info.h"
#include "ui/base/page_transition_types.h"
@@ -176,6 +177,9 @@ class CONTENT_EXPORT NavigationHandle {
// GetNetErrorCode will be net::OK.
virtual bool IsErrorPage() = 0;
+ // Returns the remote address of the socket which fetched this resource.
+ virtual net::HostPortPair GetSocketAddress() = 0;
jam 2017/01/31 23:59:44 this is used by safe browsing code (outside of con
nasko 2017/02/02 16:18:37 But I don't see changes in chrome/ in this CL. Can
jam 2017/02/03 05:26:56 Right, I'm landing each conversion separately to m
+
// Returns the response headers for the request, or nullptr if there aren't
// any response headers or they have not been received yet. The response
// headers may change during the navigation (e.g. after encountering a server
« no previous file with comments | « content/browser/renderer_host/render_view_host_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698