Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2660333006: Pass the correct webState to the nativeContent. (Closed)

Created:
3 years, 10 months ago by Olivier
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Pass the correct webState to the nativeContent. If an offline content is created in a new tab, currentWebState in the BVC will return the webState from the original tab (created tab is in background). Pass the webState from the webController instead. BUG=685969 Review-Url: https://codereview.chromium.org/2655463014 Cr-Commit-Position: refs/heads/master@{#446753} (cherry picked from commit d43eecb7ed3d688f344cc64bc4d09b7fb7e88d7a) Review-Url: https://codereview.chromium.org/2660333006 . Cr-Commit-Position: refs/branch-heads/2987@{#242} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/32243dd403ccc439ba095ad9a98facb4b0b322c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M ios/chrome/browser/ui/browser_view_controller.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/browser_view_controller_unittest.mm View 1 chunk +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/contextual_search/contextual_search_results_view.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/ui/preload_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/public/test/fakes/test_native_content_provider.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/public/web_state/ui/crw_native_content_provider.h View 2 chunks +7 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Olivier
3 years, 10 months ago (2017-02-01 08:24:26 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32243dd403ccc439ba095ad9a98facb4b0b322c9.

Powered by Google App Engine
This is Rietveld 408576698