Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2660333004: Revert of Migrate external protocol prefs from local state to profiles (Closed)

Created:
3 years, 10 months ago by tsergeant
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jdonnelly+watch_chromium.org, sky
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Migrate external protocol prefs from local state to profiles (patchset #5 id:380001 of https://codereview.chromium.org/2623033006/ ) Reason for revert: Speculative revert for crbug.com/686803: This CL appears to be causing the test MTPDeviceDelegateImplWinTest.GalleryNameMTP to fail on Win7 Tests (dbg)(1). See findit results: https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56932 and first failed build: https://luci-milo.appspot.com/buildbot/chromium.win/Win7%20Tests%20(dbg)(1)/56932 Original issue's description: > Migrate external protocol prefs from local state to profiles. > > Moves external protocol handler state from local state to per-profile. > This ensures that external protocol settings maybe distinct per-profile > and simplifies the implementation of editing UI. > > The local state data is migrated to the currently active profile and then > deleted. This may result in some loss for people who use multiple > profiles; However, they will be presented with an external protocol > dialog the next time they try and open a formerly remembered scheme. > > It also resets the state of all schemes which have been permanently > blocked by users (and are not part of the pre-populated set of schemes). > These schemes will prompt the user the next time they are accessed. We > do this because: > a) there is currently no UI to edit external handlers, so users cannot > recover from permanently silencing a dialog. > b) local state is per Chrome instance, meaning that users have to wipe > their entire Chrome data dir (or edit the local state JSON file) to recover. > > BUG=457254, 62799 > TBR=sky@chromium.org > > Review-Url: https://codereview.chromium.org/2623033006 > Cr-Commit-Position: refs/heads/master@{#446959} > Committed: https://chromium.googlesource.com/chromium/src/+/03dfa11bd46784b21cc75aa8cef21cb81435722c TBR=anthonyvd@chromium.org,dominickn@chromium.org,meacer@chromium.org,msw@chromium.org,tapted@chromium.org,davidben@chromium.org,alexmos@chromium.org,ramyasharma@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457254, 62799 Review-Url: https://codereview.chromium.org/2660333004 Cr-Commit-Position: refs/heads/master@{#447138} Committed: https://chromium.googlesource.com/chromium/src/+/c40e9f12fb5165909aaef26dc59b3cc3d6540408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -163 lines) Patch
M chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_site_per_process_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.h View 3 chunks +3 lines, -7 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler.cc View 6 chunks +32 lines, -53 lines 0 comments Download
M chrome/browser/external_protocol/external_protocol_handler_unittest.cc View 5 chunks +3 lines, -72 lines 0 comments Download
M chrome/browser/prerender/prerender_test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/external_protocol_dialog_cocoa.mm View 3 chunks +4 lines, -8 lines 0 comments Download
M chrome/browser/ui/external_protocol_dialog_delegate.cc View 3 chunks +7 lines, -16 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
tsergeant
Created Revert of Migrate external protocol prefs from local state to profiles
3 years, 10 months ago (2017-01-31 00:45:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660333004/1
3 years, 10 months ago (2017-01-31 00:46:22 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 00:47:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c40e9f12fb5165909aaef26dc59b...

Powered by Google App Engine
This is Rietveld 408576698