Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2660333003: [Merge M-57] Display "Not secure" verbose state for data: URLs (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
estark
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge M-57] Display "Not secure" verbose state for data: URLs data: URLs don't define a secure context, and are a vector for spoofing. Display a "Not secure" badge for all data URLs, regardless of whether they show a password or credit card field. BUG=684811 Review-Url: https://codereview.chromium.org/2648353005 Cr-Commit-Position: refs/heads/master@{#446536} (cherry picked from commit effd1d519ff74fb1eb998e844f19d5079222b0fd) Review-Url: https://codereview.chromium.org/2660333003 . Cr-Commit-Position: refs/branch-heads/2987@{#206} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/4278958b00456579123ad87b65663df2de8e8af6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -17 lines) Patch
M chrome/browser/ssl/security_state_tab_helper_browser_tests.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/security_state/core/security_state.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/security_state/core/security_state_unittest.cc View 9 chunks +25 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
meacer
Committed patchset #1 (id:1) manually as 4278958b00456579123ad87b65663df2de8e8af6.
3 years, 10 months ago (2017-01-31 00:35:05 UTC) #2
meacer
3 years, 10 months ago (2017-01-31 00:39:16 UTC) #4
Message was sent while issue was closed.
estark: Already landed, so please consider this your TBR.

Powered by Google App Engine
This is Rietveld 408576698