Remove HistoryController::GetPreviousEntry.

Remove HistoryController::GetPreviousEntry.

It's only tracked to update the previous navigation entry just before update.
Now that HistoryController is tracked in Chromium, just sample before updating
HistoryController.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271220

[davidben, 2014-05-02 18:22:50]

This'll want all kinds of OWNERS stamps, but as a first round, japhet for main
review. I'll add everyone else if you and try bots like this.

[Nate Chapin, 2014-05-02 18:29:02]

Awesome, thank you. This was on my list of things to do Real Soon Now. LGTM!

[davidben, 2014-05-02 20:33:38]

On 2014/05/02 18:29:02, Nate Chapin wrote:
> Awesome, thank you. This was on my list of things to do Real Soon Now. LGTM!

Apparently bots don't like it. This seems to be because of
HistoryController::GoToEntry doing its "historical quirk" where the provisional
entry gets treated as being committed immediately.

[Nate Chapin, 2014-05-02 20:35:14]

On 2014/05/02 20:33:38, David Benjamin wrote:
> On 2014/05/02 18:29:02, Nate Chapin wrote:
> > Awesome, thank you. This was on my list of things to do Real Soon Now. LGTM!
> 
> Apparently bots don't like it. This seems to be because of
> HistoryController::GoToEntry doing its "historical quirk" where the
provisional
> entry gets treated as being committed immediately.

I *was* going to fix that today, but the blink-side of the fix got reverted and
now I'm gardening :-/

I'll try to get that relanded as soon as I can and get that quirk out.

[Nate Chapin, 2014-05-16 16:49:43]

On 2014/05/02 20:35:14, Nate Chapin wrote:
> On 2014/05/02 20:33:38, David Benjamin wrote:
> > On 2014/05/02 18:29:02, Nate Chapin wrote:
> > > Awesome, thank you. This was on my list of things to do Real Soon Now.
LGTM!
> > 
> > Apparently bots don't like it. This seems to be because of
> > HistoryController::GoToEntry doing its "historical quirk" where the
> provisional
> > entry gets treated as being committed immediately.
> 
> I *was* going to fix that today, but the blink-side of the fix got reverted
and
> now I'm gardening :-/
> 
> I'll try to get that relanded as soon as I can and get that quirk out.

That quirk in HistoryController should nominally be safe to remove as of
https://codereview.chromium.org/263903006/

[davidben, 2014-05-16 18:32:25]

On 2014/05/16 16:49:43, Nate Chapin wrote:
> On 2014/05/02 20:35:14, Nate Chapin wrote:
> > On 2014/05/02 20:33:38, David Benjamin wrote:
> > > On 2014/05/02 18:29:02, Nate Chapin wrote:
> > > > Awesome, thank you. This was on my list of things to do Real Soon Now.
> LGTM!
> > > 
> > > Apparently bots don't like it. This seems to be because of
> > > HistoryController::GoToEntry doing its "historical quirk" where the
> > provisional
> > > entry gets treated as being committed immediately.
> > 
> > I *was* going to fix that today, but the blink-side of the fix got reverted
> and
> > now I'm gardening :-/
> > 
> > I'll try to get that relanded as soon as I can and get that quirk out.
> 
> That quirk in HistoryController should nominally be safe to remove as of
> https://codereview.chromium.org/263903006/

Rebased and removed the quirk HistoryController-side. The tests seem to be
passing now. Sent out another set of try jobs to confirm.

[davidben, 2014-05-16 19:43:24]

Alright, apart from Windows bots falling over, this looks green. Adding OWNERS.

droger: chrome/renderer/translate
creis: content/

[Charlie Reis, 2014-05-16 22:14:19]

Nice!  LGTM.

[droger, 2014-05-16 22:23:10]

Translate: lgtm

[davidben, 2014-05-16 22:24:58]

The CQ bit was checked by davidben@chromium.org

[commit-bot: I haz the power, 2014-05-16 23:34:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/davidben@chromium.org/266013002/40001

[commit-bot: I haz the power, 2014-05-17 16:02:55]

Change committed as 271220