Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: content/renderer/render_view_browsertest.cc

Issue 266013002: Remove HistoryController::GetPreviousEntry. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase; remove browser half of quirk. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/bind.h" 6 #include "base/bind.h"
7 #include "base/callback.h" 7 #include "base/callback.h"
8 #include "base/memory/shared_memory.h" 8 #include "base/memory/shared_memory.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 1792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1803 EXPECT_EQ(1, was_page_a); 1803 EXPECT_EQ(1, was_page_a);
1804 1804
1805 LoadHTML("<div id=pagename>Page B</div>"); 1805 LoadHTML("<div id=pagename>Page B</div>");
1806 int was_page_b = -1; 1806 int was_page_b = -1;
1807 base::string16 check_page_b = 1807 base::string16 check_page_b =
1808 base::ASCIIToUTF16( 1808 base::ASCIIToUTF16(
1809 "Number(document.getElementById('pagename').innerHTML == 'Page B')"); 1809 "Number(document.getElementById('pagename').innerHTML == 'Page B')");
1810 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b)); 1810 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b));
1811 EXPECT_EQ(1, was_page_b); 1811 EXPECT_EQ(1, was_page_b);
1812 1812
1813 PageState back_state =
1814 HistoryEntryToPageState(view()->history_controller()->GetCurrentEntry());
1815
1813 LoadHTML("<div id=pagename>Page C</div>"); 1816 LoadHTML("<div id=pagename>Page C</div>");
1814 int was_page_c = -1; 1817 int was_page_c = -1;
1815 base::string16 check_page_c = 1818 base::string16 check_page_c =
1816 base::ASCIIToUTF16( 1819 base::ASCIIToUTF16(
1817 "Number(document.getElementById('pagename').innerHTML == 'Page C')"); 1820 "Number(document.getElementById('pagename').innerHTML == 'Page C')");
1818 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c)); 1821 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c));
1819 EXPECT_EQ(1, was_page_b); 1822 EXPECT_EQ(1, was_page_b);
1820 1823
1821 PageState forward_state = 1824 PageState forward_state =
1822 HistoryEntryToPageState(view()->history_controller()->GetCurrentEntry()); 1825 HistoryEntryToPageState(view()->history_controller()->GetCurrentEntry());
1823 GoBack(HistoryEntryToPageState( 1826 GoBack(back_state);
1824 view()->history_controller()->GetPreviousEntry()));
1825 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b)); 1827 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b));
1826 EXPECT_EQ(1, was_page_b); 1828 EXPECT_EQ(1, was_page_b);
1827 1829
1830 PageState back_state2 =
1831 HistoryEntryToPageState(view()->history_controller()->GetCurrentEntry());
1832
1828 GoForward(forward_state); 1833 GoForward(forward_state);
1829 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c)); 1834 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_c, &was_page_c));
1830 EXPECT_EQ(1, was_page_c); 1835 EXPECT_EQ(1, was_page_c);
1831 1836
1832 GoBack(HistoryEntryToPageState( 1837 GoBack(back_state2);
1833 view()->history_controller()->GetPreviousEntry()));
1834 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b)); 1838 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_b, &was_page_b));
1835 EXPECT_EQ(1, was_page_b); 1839 EXPECT_EQ(1, was_page_b);
1836 1840
1837 forward_state = 1841 forward_state =
1838 HistoryEntryToPageState(view()->history_controller()->GetCurrentEntry()); 1842 HistoryEntryToPageState(view()->history_controller()->GetCurrentEntry());
1839 GoBack(page_a_state); 1843 GoBack(page_a_state);
1840 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_a, &was_page_a)); 1844 EXPECT_TRUE(ExecuteJavaScriptAndReturnIntValue(check_page_a, &was_page_a));
1841 EXPECT_EQ(1, was_page_a); 1845 EXPECT_EQ(1, was_page_a);
1842 1846
1843 GoForward(forward_state); 1847 GoForward(forward_state);
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
2361 view()->renderer_accessibility()->GetType()); 2365 view()->renderer_accessibility()->GetType());
2362 2366
2363 view()->OnSetAccessibilityMode(AccessibilityModeEditableTextOnly); 2367 view()->OnSetAccessibilityMode(AccessibilityModeEditableTextOnly);
2364 ASSERT_EQ(AccessibilityModeEditableTextOnly, view()->accessibility_mode()); 2368 ASSERT_EQ(AccessibilityModeEditableTextOnly, view()->accessibility_mode());
2365 ASSERT_NE((RendererAccessibility*) NULL, view()->renderer_accessibility()); 2369 ASSERT_NE((RendererAccessibility*) NULL, view()->renderer_accessibility());
2366 ASSERT_EQ(RendererAccessibilityTypeFocusOnly, 2370 ASSERT_EQ(RendererAccessibilityTypeFocusOnly,
2367 view()->renderer_accessibility()->GetType()); 2371 view()->renderer_accessibility()->GetType());
2368 } 2372 }
2369 2373
2370 } // namespace content 2374 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698