Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2660123002: ThinStrings: fix CodeStubAssembler::SubString (Closed)

Created:
3 years, 10 months ago by Jakob Kummerow
Modified:
3 years, 10 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ThinStrings: fix CodeStubAssembler::SubString BUG=chromium:685965 Review-Url: https://codereview.chromium.org/2660123002 Cr-Commit-Position: refs/heads/master@{#42782} Committed: https://chromium.googlesource.com/v8/v8/+/9ea3e56bd9e5c9204aad58a17ba464247358d51e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -14 lines) Patch
M src/code-stub-assembler.cc View 3 chunks +19 lines, -14 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-685965.js View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Jakob Kummerow
PTAL.
3 years, 10 months ago (2017-01-30 06:57:38 UTC) #6
Igor Sheludko
lgtm
3 years, 10 months ago (2017-01-30 16:53:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660123002/1
3 years, 10 months ago (2017-01-30 18:15:59 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:17:58 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/9ea3e56bd9e5c9204aad58a17ba46424735...

Powered by Google App Engine
This is Rietveld 408576698