Fix --noopt to not optimize

Fix --noopt to not optimize

BUG=v8:5904, chromium:639217
R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2660103002
Cr-Commit-Position: refs/heads/master@{#42777}
Committed: https://chromium.googlesource.com/v8/v8/+/1fc5ca85fcc5bb75bd9b27eaf434f03cb5bf61fc

[jochen (gone - plz use gerrit), 2017-01-29 00:42:22]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 00:42:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 00:57:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 00:57:37]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[jochen (gone - plz use gerrit), 2017-01-29 01:09:41]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 01:09:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 01:40:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 01:40:31]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2017-01-30 09:27:52]

mstarzinger@chromium.org changed reviewers:
+ ishell@chromium.org

[Michael Starzinger, 2017-01-30 09:27:53]

LGTM with one suggestion, also +Igor for FYI.

https://codereview.chromium.org/2660103002/diff/20001/src/v8.cc
File src/v8.cc (right):

https://codereview.chromium.org/2660103002/diff/20001/src/v8.cc#newcode69
src/v8.cc:69: if (FLAG_opt && FLAG_turbo && strcmp(FLAG_turbo_filter, "~~") ==
0) {
suggestion: Igor made --turbo imply --crankshaft, to make these two flags stay
in sync we should make --turbo imply --opt as well. WDYT?

[jochen (gone - plz use gerrit), 2017-01-30 14:08:42]

The CQ bit was checked by jochen@chromium.org

[jochen (gone - plz use gerrit), 2017-01-30 14:08:43]

https://codereview.chromium.org/2660103002/diff/20001/src/v8.cc
File src/v8.cc (right):

https://codereview.chromium.org/2660103002/diff/20001/src/v8.cc#newcode69
src/v8.cc:69: if (FLAG_opt && FLAG_turbo && strcmp(FLAG_turbo_filter, "~~") ==
0) {
On 2017/01/30 at 09:27:53, Michael Starzinger wrote:
> suggestion: Igor made --turbo imply --crankshaft, to make these two flags stay
in sync we should make --turbo imply --opt as well. WDYT?

that would mean that if we set --turbo via finch, --noopt wouldn't work anymore

[commit-bot: I haz the power, 2017-01-30 14:08:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 14:41:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485785322931820,
"parent_rev": "f87ce44f527c1c96a25e7e6df0bc0d4f829a1d90", "commit_rev":
"1fc5ca85fcc5bb75bd9b27eaf434f03cb5bf61fc"}

[commit-bot: I haz the power, 2017-01-30 14:41:34]

Description was changed from

==========
Fix --noopt to not optimize

BUG=v8:5904,chromium:639217
R=mstarzinger@chromium.org
==========

to

==========
Fix --noopt to not optimize

BUG=v8:5904,chromium:639217
R=mstarzinger@chromium.org

Review-Url: https://codereview.chromium.org/2660103002
Cr-Commit-Position: refs/heads/master@{#42777}
Committed:
https://chromium.googlesource.com/v8/v8/+/1fc5ca85fcc5bb75bd9b27eaf434f03cb5b...
==========

[commit-bot: I haz the power, 2017-01-30 14:41:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/1fc5ca85fcc5bb75bd9b27eaf434f03cb5b...