Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2200)

Unified Diff: Tools/TestResultServer/handlers/buildershandler_unittest.py

Issue 26601003: Fix get_latest_build to return actual latest build (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: remove redundant test. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Tools/TestResultServer/handlers/buildershandler.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Tools/TestResultServer/handlers/buildershandler_unittest.py
diff --git a/Tools/TestResultServer/handlers/buildershandler_unittest.py b/Tools/TestResultServer/handlers/buildershandler_unittest.py
index 02dbc4cb42d51aafc6a1b65aa33c112f6c0abca1..47fa6efe340bf26aa627fbc8f6d1d8cab12f15e4 100644
--- a/Tools/TestResultServer/handlers/buildershandler_unittest.py
+++ b/Tools/TestResultServer/handlers/buildershandler_unittest.py
@@ -50,30 +50,34 @@ class BuildersHandlerTest(unittest.TestCase):
'currentBuilds': ['3'],
'basedir': 'fake'}
latest_build = buildershandler.get_latest_build(build_data)
-
self.assertEqual(latest_build, '2')
build_data = {'cachedBuilds': [],
'currentBuilds': ['1', '2', '3'],
'basedir': 'fake'}
latest_build = buildershandler.get_latest_build(build_data)
-
self.assertEqual(latest_build, '1')
build_data = {'cachedBuilds': ['1', '2', '3'],
'currentBuilds': ['1', '2', '3'],
'basedir': 'fake'}
latest_build = buildershandler.get_latest_build(build_data)
-
self.assertEqual(latest_build, '1')
build_data = {'cachedBuilds': [],
'currentBuilds': [],
'basedir': 'fake'}
latest_build = buildershandler.get_latest_build(build_data)
-
self.assertEqual(latest_build, None)
+ long_list = map(lambda x: str(x), xrange(1000, 1200))
+ current_build = long_list[-1]
+ build_data = {'cachedBuilds': long_list[:],
+ 'currentBuilds': [current_build],
+ 'basedir': 'fake'}
+ latest_build = buildershandler.get_latest_build(build_data)
+ self.assertEqual(latest_build, long_list[-2])
+
def test_fetch_buildbot_data(self):
try:
fetched_urls = []
« no previous file with comments | « Tools/TestResultServer/handlers/buildershandler.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698