Tools/TestResultServer/handlers/buildershandler.py - Issue 26601003: Fix get_latest_build to return actual latest build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/TestResultServer/handlers/buildershandler.py

Issue 26601003: Fix get_latest_build to return actual latest build (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove redundant test. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/TestResultServer/handlers/buildershandler.py

diff --git a/Tools/TestResultServer/handlers/buildershandler.py b/Tools/TestResultServer/handlers/buildershandler.py

index 966c9c728a373a88776b66d7091c1f5f00f02660..1d0bd62c3f0756ba299bc3eb05f7921d9785b920 100644

--- a/Tools/TestResultServer/handlers/buildershandler.py

+++ b/Tools/TestResultServer/handlers/buildershandler.py

@@ -90,7 +90,8 @@ def get_latest_build(build_data):

latest_cached_builds = set(cached_builds) - set(current_builds)

if len(latest_cached_builds) != 0:

- latest_build = list(latest_cached_builds)[-1]

+ latest_cached_builds = sorted(list(latest_cached_builds))

+ latest_build = latest_cached_builds[-1]

elif len(current_builds) != 0:

latest_build = current_builds[0]

else:

« no previous file with comments | « no previous file | Tools/TestResultServer/handlers/buildershandler_unittest.py » ('j') | no next file with comments »