Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2660063002: Revert of [turbofan] Enable escape analysis. (Closed)

Created:
3 years, 10 months ago by Jarin
Modified:
3 years, 10 months ago
Reviewers:
Tobias Tebbi
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Enable escape analysis. (patchset #1 id:1 of https://codereview.chromium.org/2626013002/ ) Reason for revert: Temporarily turn off escape analysis to get a clean canary. Original issue's description: > [turbofan] Enable escape analysis. > > Review-Url: https://codereview.chromium.org/2626013002 > Cr-Commit-Position: refs/heads/master@{#42229} > Committed: https://chromium.googlesource.com/v8/v8/+/30176976e857d4eb84a93fface84849c44bab793 TBR=tebbi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/2660063002 Cr-Commit-Position: refs/heads/master@{#42755} Committed: https://chromium.googlesource.com/v8/v8/+/e342ec90f05990b730b1f5b9699e74166330f1c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/flag-definitions.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jarin
Created Revert of [turbofan] Enable escape analysis.
3 years, 10 months ago (2017-01-28 16:42:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2660063002/1
3 years, 10 months ago (2017-01-28 16:42:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/e342ec90f05990b730b1f5b9699e74166330f1c8
3 years, 10 months ago (2017-01-28 17:18:13 UTC) #6
Tobias Tebbi
3 years, 10 months ago (2017-01-30 08:33:08 UTC) #7
Message was sent while issue was closed.
On 2017/01/28 17:18:13, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/v8/v8/+/e342ec90f05990b730b1f5b9699e7416633...

lgtm

Powered by Google App Engine
This is Rietveld 408576698