Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2659993002: Revert of Remove /resources/ from a vector_icon.h include to fix Google Chrome Mac compile (Closed)

Created:
3 years, 10 months ago by mdjones
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, tfarina, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove /resources/ from a vector_icon.h include to fix Google Chrome Mac compile (patchset #1 id:1 of https://codereview.chromium.org/2659133002/ ) Reason for revert: Compile error on GPU Mac Builder: ../../ui/views/style/platform_style_mac.mm:15:10: fatal error: 'ui/views/vector_icons/vector_icons.h' file not found Original issue's description: > Remove /resources/ from a vector_icon.h include to fix Google Chrome Mac compile > > TBR=estade@chromium.org > BUG=684911 > NOTRY=true > NOTREECHECKS=true > NOPRESUBMIT=true > > Review-Url: https://codereview.chromium.org/2659133002 > Cr-Commit-Position: refs/heads/master@{#446785} > Committed: https://chromium.googlesource.com/chromium/src/+/bc2e9b86da06f3f673ff175001e8b886500102b2 TBR=estade@chromium.org,dbeam@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=684911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/views/style/platform_style_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (2 generated)
mdjones
Created Revert of Remove /resources/ from a vector_icon.h include to fix Google Chrome Mac compile
3 years, 10 months ago (2017-01-27 22:15:21 UTC) #2
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 22:16:30 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698