Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2659953002: Convert SelfDeletingRequestDelegate to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert SelfDeletingRequestDelegate to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2659953002 Cr-Commit-Position: refs/heads/master@{#446818} Committed: https://chromium.googlesource.com/chromium/src/+/506c250363a28b39338e69aaa50bc83707fe5767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M chrome/browser/dom_distiller/tab_utils.cc View 3 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 10 months ago (2017-01-27 20:31:59 UTC) #4
nyquist
lgtm
3 years, 10 months ago (2017-01-27 22:54:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659953002/1
3 years, 10 months ago (2017-01-27 23:05:52 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 23:13:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/506c250363a28b39338e69aaa50b...

Powered by Google App Engine
This is Rietveld 408576698