Issue 26599003: Enable the SVG GlobalEventHandlers test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26599003: Enable the SVG GlobalEventHandlers test (Closed)

Created:
7 years, 2 months ago by philipj_slow

Modified:
7 years, 2 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Enable the SVG GlobalEventHandlers test I forgot this in a previous commit. It turns out that SVGSVGElement forwards some of these properties to window, which broke the tests, so use a SVGRectElement for testing instead. BUG=305112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159689

Patch Set 1 #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+182 lines, -2 lines)			Patch
	M	LayoutTests/fast/dom/global-event-handlers.html	View		3 chunks	+5 lines, -2 lines	0 comments	Download
	M	LayoutTests/fast/dom/global-event-handlers-expected.txt	View		59 chunks	+177 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26599003/1

7 years, 2 months ago (2013-10-15 16:56:49 UTC) #3

Message was sent while issue was closed.

Change committed as 159689

Expand Messages | Collapse Messages