Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(34)

Issue 26599003: Enable the SVG GlobalEventHandlers test (Closed)

Created:
5 years, 10 months ago by philipj_slow
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable the SVG GlobalEventHandlers test I forgot this in a previous commit. It turns out that SVGSVGElement forwards some of these properties to window, which broke the tests, so use a SVGRectElement for testing instead. BUG=305112 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -2 lines) Patch
M LayoutTests/fast/dom/global-event-handlers.html View 3 chunks +5 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/global-event-handlers-expected.txt View 59 chunks +177 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
5 years, 10 months ago (2013-10-13 19:41:13 UTC) #1
abarth-chromium
lgtm
5 years, 10 months ago (2013-10-15 16:56:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/26599003/1
5 years, 10 months ago (2013-10-15 16:56:49 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2013-10-15 20:25:05 UTC) #4
Message was sent while issue was closed.
Change committed as 159689

Powered by Google App Engine
This is Rietveld 408576698