Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2659883003: cc: Remove direct calls to LayerImpl::SetHasRenderSurface from tests (Closed)

Created:
3 years, 10 months ago by ajuma
Modified:
3 years, 10 months ago
Reviewers:
jaydasika, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove direct calls to LayerImpl::SetHasRenderSurface from tests This replaces most calls to LayerImpl::SetHasRenderSurface in unit tests with setting LayerImpl::test_properties::force_render_surface, except for calls that involve the root layer and calls in LayerImplTests. Calls that involve the root layer are just deleted without replacement, since the root layer always has a render surface. Calls in LayerImplTests can be deleted when LayerImpl::SetHasRenderSurface is itself deleted. BUG=611883 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2659883003 Cr-Commit-Position: refs/heads/master@{#446776} Committed: https://chromium.googlesource.com/chromium/src/+/35b24f6319f8516d7393dd8cd68225cf0cedaa2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -24 lines) Patch
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/render_surface_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/render_surface_unittest.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/tiles/tile_manager_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 7 chunks +6 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
ajuma
3 years, 10 months ago (2017-01-27 19:52:56 UTC) #6
weiliangc
LGTM
3 years, 10 months ago (2017-01-27 19:55:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659883003/1
3 years, 10 months ago (2017-01-27 21:04:55 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 21:23:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/35b24f6319f8516d7393dd8cd682...

Powered by Google App Engine
This is Rietveld 408576698