Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2659853006: Add getFrameData and getPose layout tests (Closed)

Created:
3 years, 10 months ago by bsheedy
Modified:
3 years, 10 months ago
Reviewers:
bajones
CC:
chromium-reviews, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add getFrameData and getPose layout tests Adds layout tests for WebVR using getFrameData and getPose now that pose updating doesn't hang indefinitely while mocking. BUG=675325 Review-Url: https://codereview.chromium.org/2659853006 Cr-Commit-Position: refs/heads/master@{#447017} Committed: https://chromium.googlesource.com/chromium/src/+/90efe3450f9f29a5535bce77249d064b354ff378

Patch Set 1 #

Patch Set 2 : Add more tests #

Messages

Total messages: 8 (4 generated)
bsheedy
PTAL, and feel free to suggest any areas where more coverage could be added.
3 years, 10 months ago (2017-01-28 00:54:15 UTC) #2
bajones
LGTM!
3 years, 10 months ago (2017-01-28 19:54:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659853006/20001
3 years, 10 months ago (2017-01-30 17:28:41 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 18:34:51 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/90efe3450f9f29a5535bce77249d...

Powered by Google App Engine
This is Rietveld 408576698