Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2659853005: cros: Fix crash after killing preloaded lock screen in task manager. (Closed)

Created:
3 years, 10 months ago by jdufault
Modified:
3 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix crash after killing preloaded lock screen in task manager. Crash happens when showing the lock screen after killing a preloaded one in the task manager. BUG=669638 Review-Url: https://codereview.chromium.org/2659853005 Cr-Commit-Position: refs/heads/master@{#447043} Committed: https://chromium.googlesource.com/chromium/src/+/b65749b36134548e2cc8463b10c63704dccbf396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/browser/chromeos/login/ui/preloaded_web_view.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
jdufault
xiyuan@ PTAL. Thanks
3 years, 10 months ago (2017-01-28 01:05:28 UTC) #7
xiyuan
lgtm
3 years, 10 months ago (2017-01-30 17:05:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659853005/1
3 years, 10 months ago (2017-01-30 19:23:20 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 20:06:18 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b65749b36134548e2cc8463b10c6...

Powered by Google App Engine
This is Rietveld 408576698