Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 2659843005: Compile content_unittests service catalog directly into the binary (Closed)

Created:
3 years, 10 months ago by Ken Rockot(use gerrit already)
Modified:
3 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Compile content_unittests service catalog directly into the binary This avoids loading the catalog from disk in startup, eliminating a runtime dependency and allowing us to run service tests here on Android. Also enables the service-consuming local storage tests on Android now that they work. BUG=677194 TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2659843005 Cr-Commit-Position: refs/heads/master@{#446885} Committed: https://chromium.googlesource.com/chromium/src/+/a60bd4e8eaf30ee4de91922311ed111ff687400e

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -65 lines) Patch
M content/browser/dom_storage/local_storage_context_mojo_unittest.cc View 1 4 chunks +4 lines, -32 lines 0 comments Download
M content/test/BUILD.gn View 3 chunks +4 lines, -9 lines 0 comments Download
M content/test/run_all_unittests.cc View 1 chunk +3 lines, -24 lines 0 comments Download

Messages

Total messages: 23 (15 generated)
Ken Rockot(use gerrit already)
Marijn, could you please take a look at your tests?
3 years, 10 months ago (2017-01-27 21:54:07 UTC) #7
Marijn Kruisselbrink
On 2017/01/27 at 21:54:07, rockot wrote: > Marijn, could you please take a look at ...
3 years, 10 months ago (2017-01-27 22:34:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659843005/20001
3 years, 10 months ago (2017-01-27 22:36:44 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/352554)
3 years, 10 months ago (2017-01-27 22:46:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659843005/20001
3 years, 10 months ago (2017-01-27 22:49:19 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/222312)
3 years, 10 months ago (2017-01-28 00:55:02 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659843005/20001
3 years, 10 months ago (2017-01-28 00:56:22 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 02:13:05 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a60bd4e8eaf30ee4de91922311ed...

Powered by Google App Engine
This is Rietveld 408576698