Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2659823004: Add deprecation messages for blocked subresource types. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/Deprecation.cpp
diff --git a/third_party/WebKit/Source/core/frame/Deprecation.cpp b/third_party/WebKit/Source/core/frame/Deprecation.cpp
index f0bbf76ba7c16a6b5b221d2332cd7c9f08b67d15..bff97717e7d01258c7c264ad14774328a8e33e77 100644
--- a/third_party/WebKit/Source/core/frame/Deprecation.cpp
+++ b/third_party/WebKit/Source/core/frame/Deprecation.cpp
@@ -268,6 +268,24 @@ String Deprecation::deprecationMessage(UseCounter::Feature feature) {
case UseCounter::RangeExpand:
return replacedBy("'Range.expand()'", "'Selection.modify()'");
+ // Blocked subresource requests:
+ case UseCounter::LegacyProtocolEmbeddedAsSubresource:
+ return String::format(
+ "Subresource requests using legacy protocols (like `ftp:`) are "
+ "deprecated, and will be blocked in %s. Please deliver "
+ "web-accessible resources over modern protocols like HTTPS. "
+ "See https://www.chromestatus.com/feature/5709390967472128 for more "
+ "details.",
+ milestoneString(M59));
+
+ case UseCounter::RequestedSubresourceWithEmbeddedCredentials:
+ return String::format(
+ "Subresource requests whose URLs contain embedded credentials (e.g. "
+ "`https://user:pass@host/`) are deprecated, and will be blocked in "
+ "%s. See https://www.chromestatus.com/feature/5669008342777856 for "
+ "more details.",
+ milestoneString(M59));
+
// Powerful features on insecure origins (https://goo.gl/rStTGz)
case UseCounter::DeviceMotionInsecureOrigin:
return "The devicemotion event is deprecated on insecure origins, and "

Powered by Google App Engine
This is Rietveld 408576698