Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Side by Side Diff: third_party/WebKit/Source/core/frame/Deprecation.cpp

Issue 2659823004: Add deprecation messages for blocked subresource types. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/Deprecation.h" 5 #include "core/frame/Deprecation.h"
6 6
7 #include "core/dom/Document.h" 7 #include "core/dom/Document.h"
8 #include "core/dom/ExecutionContext.h" 8 #include "core/dom/ExecutionContext.h"
9 #include "core/frame/FrameConsole.h" 9 #include "core/frame/FrameConsole.h"
10 #include "core/frame/FrameHost.h" 10 #include "core/frame/FrameHost.h"
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 case UseCounter::GetMatchedCSSRules: 261 case UseCounter::GetMatchedCSSRules:
262 return "'getMatchedCSSRules()' is deprecated. For more help, check " 262 return "'getMatchedCSSRules()' is deprecated. For more help, check "
263 "https://code.google.com/p/chromium/issues/detail?id=437569#c2"; 263 "https://code.google.com/p/chromium/issues/detail?id=437569#c2";
264 264
265 case UseCounter::PrefixedWindowURL: 265 case UseCounter::PrefixedWindowURL:
266 return replacedBy("'webkitURL'", "'URL'"); 266 return replacedBy("'webkitURL'", "'URL'");
267 267
268 case UseCounter::RangeExpand: 268 case UseCounter::RangeExpand:
269 return replacedBy("'Range.expand()'", "'Selection.modify()'"); 269 return replacedBy("'Range.expand()'", "'Selection.modify()'");
270 270
271 // Blocked subresource requests:
272 case UseCounter::LegacyProtocolEmbeddedAsSubresource:
273 return String::format(
274 "Subresource requests using legacy protocols (like `ftp:`) are "
275 "deprecated, and will be blocked in %s. Please deliver "
276 "web-accessible resources over modern protocols like HTTPS. "
277 "See https://www.chromestatus.com/feature/5709390967472128 for more "
278 "details.",
279 milestoneString(M59));
280
281 case UseCounter::RequestedSubresourceWithEmbeddedCredentials:
282 return String::format(
283 "Subresource requests whose URLs contain embedded credentials (e.g. "
284 "`https://user:pass@host/`) are deprecated, and will be blocked in "
285 "%s. See https://www.chromestatus.com/feature/5669008342777856 for "
286 "more details.",
287 milestoneString(M59));
288
271 // Powerful features on insecure origins (https://goo.gl/rStTGz) 289 // Powerful features on insecure origins (https://goo.gl/rStTGz)
272 case UseCounter::DeviceMotionInsecureOrigin: 290 case UseCounter::DeviceMotionInsecureOrigin:
273 return "The devicemotion event is deprecated on insecure origins, and " 291 return "The devicemotion event is deprecated on insecure origins, and "
274 "support will be removed in the future. You should consider " 292 "support will be removed in the future. You should consider "
275 "switching your application to a secure origin, such as HTTPS. " 293 "switching your application to a secure origin, such as HTTPS. "
276 "See https://goo.gl/rStTGz for more details."; 294 "See https://goo.gl/rStTGz for more details.";
277 295
278 case UseCounter::DeviceOrientationInsecureOrigin: 296 case UseCounter::DeviceOrientationInsecureOrigin:
279 return "The deviceorientation event is deprecated on insecure origins, " 297 return "The deviceorientation event is deprecated on insecure origins, "
280 "and support will be removed in the future. You should consider " 298 "and support will be removed in the future. You should consider "
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
412 "-internal-media-controls-text-track-list* selectors", M59, 430 "-internal-media-controls-text-track-list* selectors", M59,
413 "5661431349379072"); 431 "5661431349379072");
414 432
415 // Features that aren't deprecated don't have a deprecation message. 433 // Features that aren't deprecated don't have a deprecation message.
416 default: 434 default:
417 return String(); 435 return String();
418 } 436 }
419 } 437 }
420 438
421 } // namespace blink 439 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698