chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc - Issue 2659813006: Always get device conditions from Java for every attempt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2659813006: Always get device conditions from Java for every attempt. (Closed)

Patch Set: fixes per DewittJ Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/evaluation/evaluation_test_scheduler.cc ('k') | components/offline_pages/core/background/request_coordinator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

diff --git a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

index 36a153d882b8fb181ad99309e9774a9b68ac904c..b2074cf1a45f6a09c318cdcb39b21fb208401841 100644

--- a/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

+++ b/chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

@@ -319,11 +319,8 @@ bool OfflinePageEvaluationBridge::PushRequestProcessing(

DCHECK(request_coordinator_);

base::android::RunCallbackAndroid(j_callback_obj, false);

- net::NetworkChangeNotifier::ConnectionType connection =

- net::NetworkChangeNotifier::GetConnectionType();

- DeviceConditions device_conditions(false, 0, connection);

return request_coordinator_->StartImmediateProcessing(

- device_conditions, base::Bind(&OnPushRequestsDone, j_callback_ref));

+ base::Bind(&OnPushRequestsDone, j_callback_ref));

}

void OfflinePageEvaluationBridge::SavePageLater(