Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc

Issue 2659813006: Always get device conditions from Java for every attempt. (Closed)
Patch Set: fixes per DewittJ Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h" 5 #include "chrome/browser/android/offline_pages/evaluation/offline_page_evaluatio n_bridge.h"
6 6
7 #include "base/android/callback_android.h" 7 #include "base/android/callback_android.h"
8 #include "base/android/jni_android.h" 8 #include "base/android/jni_android.h"
9 #include "base/android/jni_array.h" 9 #include "base/android/jni_array.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 } 312 }
313 313
314 bool OfflinePageEvaluationBridge::PushRequestProcessing( 314 bool OfflinePageEvaluationBridge::PushRequestProcessing(
315 JNIEnv* env, 315 JNIEnv* env,
316 const JavaParamRef<jobject>& obj, 316 const JavaParamRef<jobject>& obj,
317 const JavaParamRef<jobject>& j_callback_obj) { 317 const JavaParamRef<jobject>& j_callback_obj) {
318 ScopedJavaGlobalRef<jobject> j_callback_ref(j_callback_obj); 318 ScopedJavaGlobalRef<jobject> j_callback_ref(j_callback_obj);
319 DCHECK(request_coordinator_); 319 DCHECK(request_coordinator_);
320 base::android::RunCallbackAndroid(j_callback_obj, false); 320 base::android::RunCallbackAndroid(j_callback_obj, false);
321 321
322 net::NetworkChangeNotifier::ConnectionType connection =
323 net::NetworkChangeNotifier::GetConnectionType();
324 DeviceConditions device_conditions(false, 0, connection);
325 return request_coordinator_->StartImmediateProcessing( 322 return request_coordinator_->StartImmediateProcessing(
326 device_conditions, base::Bind(&OnPushRequestsDone, j_callback_ref)); 323 base::Bind(&OnPushRequestsDone, j_callback_ref));
327 } 324 }
328 325
329 void OfflinePageEvaluationBridge::SavePageLater( 326 void OfflinePageEvaluationBridge::SavePageLater(
330 JNIEnv* env, 327 JNIEnv* env,
331 const JavaParamRef<jobject>& obj, 328 const JavaParamRef<jobject>& obj,
332 const JavaParamRef<jstring>& j_url, 329 const JavaParamRef<jstring>& j_url,
333 const JavaParamRef<jstring>& j_namespace, 330 const JavaParamRef<jstring>& j_namespace,
334 const JavaParamRef<jstring>& j_client_id, 331 const JavaParamRef<jstring>& j_client_id,
335 jboolean user_requested) { 332 jboolean user_requested) {
336 offline_pages::ClientId client_id; 333 offline_pages::ClientId client_id;
(...skipping 29 matching lines...) Expand all
366 363
367 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const { 364 void OfflinePageEvaluationBridge::NotifyIfDoneLoading() const {
368 if (!offline_page_model_->is_loaded()) 365 if (!offline_page_model_->is_loaded())
369 return; 366 return;
370 JNIEnv* env = base::android::AttachCurrentThread(); 367 JNIEnv* env = base::android::AttachCurrentThread();
371 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_); 368 Java_OfflinePageEvaluationBridge_offlinePageModelLoaded(env, java_ref_);
372 } 369 }
373 370
374 } // namespace android 371 } // namespace android
375 } // namespace offline_pages 372 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698