Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 2659803003: Upon deletion of the profile don't fallback on current if it supervised. (Closed)

Created:
3 years, 10 months ago by palar
Modified:
3 years, 10 months ago
CC:
chromium-reviews, rginda+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upon deletion of the profile don't fallback on current if it supervised. BUG=686035 R=anthonyvd@chromium.org, bauerb@chromium.org Review-Url: https://codereview.chromium.org/2659803003 Cr-Commit-Position: refs/heads/master@{#447235} Committed: https://chromium.googlesource.com/chromium/src/+/c5cdb47188549b4d5c9ce8905dc8d1edd797cd07

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M chrome/browser/profiles/profile_manager.cc View 1 chunk +8 lines, -5 lines 1 comment Download

Messages

Total messages: 14 (5 generated)
palar
3 years, 10 months ago (2017-01-27 15:21:26 UTC) #1
Bernhard Bauer
https://codereview.chromium.org/2659803003/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/2659803003/diff/1/chrome/browser/profiles/profile_manager.cc#newcode1377 chrome/browser/profiles/profile_manager.cc:1377: last_used_profile != nullptr && Can the last used profile ...
3 years, 10 months ago (2017-01-27 16:17:40 UTC) #2
palar
On 2017/01/27 16:17:40, Bernhard Bauer wrote: > https://codereview.chromium.org/2659803003/diff/1/chrome/browser/profiles/profile_manager.cc > File chrome/browser/profiles/profile_manager.cc (right): > > https://codereview.chromium.org/2659803003/diff/1/chrome/browser/profiles/profile_manager.cc#newcode1377 ...
3 years, 10 months ago (2017-01-30 10:51:18 UTC) #3
Bernhard Bauer
LGTM
3 years, 10 months ago (2017-01-30 15:20:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659803003/1
3 years, 10 months ago (2017-01-30 15:28:18 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/353131)
3 years, 10 months ago (2017-01-30 15:37:27 UTC) #8
anthonyvd
lgtm
3 years, 10 months ago (2017-01-31 14:43:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659803003/1
3 years, 10 months ago (2017-01-31 15:23:10 UTC) #11
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 15:27:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c5cdb47188549b4d5c9ce8905dc8...

Powered by Google App Engine
This is Rietveld 408576698