Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2659753002: Convert MobileSetupUI to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert MobileSetupUI to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2659753002 Cr-Commit-Position: refs/heads/master@{#446593} Committed: https://chromium.googlesource.com/chromium/src/+/e56024e9bcb988df909d4914aa48ea762b5cd0d3

Patch Set 1 #

Patch Set 2 : include #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -27 lines) Patch
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.h View 1 chunk +2 lines, -9 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc View 1 2 2 chunks +13 lines, -18 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jam
3 years, 10 months ago (2017-01-26 23:00:11 UTC) #7
achuithb
lgtm with optional nit https://codereview.chromium.org/2659753002/diff/20001/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right): https://codereview.chromium.org/2659753002/diff/20001/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc#newcode643 chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:643: result_value); Early return on error ...
3 years, 10 months ago (2017-01-27 01:14:59 UTC) #10
jam
https://codereview.chromium.org/2659753002/diff/20001/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc File chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc (right): https://codereview.chromium.org/2659753002/diff/20001/chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc#newcode643 chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc:643: result_value); On 2017/01/27 01:14:59, achuithb wrote: > Early return ...
3 years, 10 months ago (2017-01-27 04:06:24 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659753002/40001
3 years, 10 months ago (2017-01-27 04:07:23 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-01-27 04:40:15 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e56024e9bcb988df909d4914aa48...

Powered by Google App Engine
This is Rietveld 408576698