Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.

Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.

Chrome/Blink doesn't use any of the legacy methods behind this flag any more.

BUG=skia:2187
Committed: http://code.google.com/p/skia/source/detail?r=14651

Committed: http://code.google.com/p/skia/source/detail?r=14692

[Dominik Grewe, 2014-05-02 15:50:39]

PTAL

[Dominik Grewe, 2014-05-08 16:21:03]

On 2014/05/02 15:50:39, Dominik Grewe wrote:
> PTAL

ping?

[reed1, 2014-05-08 16:52:21]

lgtm

[Dominik Grewe, 2014-05-08 16:55:15]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-05-08 16:56:36]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/265973002/1

[Dominik Grewe, 2014-05-08 16:58:39]

The CQ bit was unchecked by dominikg@chromium.org

[Dominik Grewe, 2014-05-08 17:09:35]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-05-08 17:10:23]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/265973002/20001

[commit-bot: I haz the power, 2014-05-08 18:13:18]

Change committed as 14651

[robertphillips, 2014-05-09 00:04:01]

A revert of this CL has been created in
https://codereview.chromium.org/275713002/ by robertphillips@google.com.

The reason for reverting is: This is breaking compilation of cc_unittests in
Chrome.

[Dominik Grewe, 2014-05-09 10:36:30]

On 2014/05/09 00:04:01, robertphillips wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/275713002/ by
mailto:robertphillips@google.com.
> 
> The reason for reverting is: This is breaking compilation of cc_unittests in
> Chrome.

Sorry about that. I forgot to update the tests. I've got a CL for that now and
I'll re-land this once it has landed.

[Dominik Grewe, 2014-05-12 14:10:51]

On 2014/05/09 10:36:30, Dominik Grewe wrote:
> On 2014/05/09 00:04:01, robertphillips wrote:
> > A revert of this CL has been created in
> > https://codereview.chromium.org/275713002/ by
> mailto:robertphillips@google.com.
> > 
> > The reason for reverting is: This is breaking compilation of cc_unittests in
> > Chrome.
> 
> Sorry about that. I forgot to update the tests. I've got a CL for that now and
> I'll re-land this once it has landed.

My Chromium patch has landed. Giving this another go.

[Dominik Grewe, 2014-05-12 14:12:20]

The CQ bit was checked by dominikg@chromium.org

[commit-bot: I haz the power, 2014-05-12 14:12:32]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/dominikg@chromium.org/265973002/20001

[commit-bot: I haz the power, 2014-05-12 14:12:40]

Change committed as 14692