gyp/skia_for_chromium_defines.gypi - Issue 265973002: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gyp/skia_for_chromium_defines.gypi

Issue 265973002: Remove SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS flag from chromium_defines. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gyp/skia_for_chromium_defines.gypi

diff --git a/gyp/skia_for_chromium_defines.gypi b/gyp/skia_for_chromium_defines.gypi

index 2702e3517f92276b9462807b10d4e63218e531e0..632c532513098410cf6c01ac9ae9a02c5e3875b1 100644

--- a/gyp/skia_for_chromium_defines.gypi

+++ b/gyp/skia_for_chromium_defines.gypi

@@ -13,7 +13,6 @@

# If these become 'permanent', they should be moved into skia_common.gypi

'skia_for_chromium_defines': [

- 'SK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1',

'SK_SUPPORT_LEGACY_GETTOPDEVICE',

'SK_SUPPORT_LEGACY_N32_NAME',

'SK_SUPPORT_LEGACY_BUILDMIPMAP',

« no previous file with comments | « no previous file | no next file » | no next file with comments »