Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 2659623003: Re-enable FramedBrowserWindowTest.DoesHideTitle (Closed)

Created:
3 years, 10 months ago by tapted
Modified:
3 years, 10 months ago
Reviewers:
Sidney San Martín
CC:
chromium-reviews, mac-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable FramedBrowserWindowTest.DoesHideTitle This started failing on 10.11 after r424609 landed, which was a change to start using NSFullSizeContentViewWindowMask for the browser window. However, that's been disabled since r433658, so this test should keep running. BUG=655112 Review-Url: https://codereview.chromium.org/2659623003 Cr-Commit-Position: refs/heads/master@{#447247} Committed: https://chromium.googlesource.com/chromium/src/+/9423656f22bc945169a6337b4e2001ec67ba9646

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/cocoa/framed_browser_window_unittest.mm View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
tapted
Hi Sidney, PTAL (and feel free to CQ) - thanks!
3 years, 10 months ago (2017-01-27 05:35:38 UTC) #8
tapted
sdy: ping?
3 years, 10 months ago (2017-01-31 10:58:44 UTC) #9
Sidney San Martín
lgtm
3 years, 10 months ago (2017-01-31 16:39:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659623003/1
3 years, 10 months ago (2017-01-31 16:40:05 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-01-31 16:56:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9423656f22bc945169a6337b4e20...

Powered by Google App Engine
This is Rietveld 408576698