Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/browser/extension_event_histogram_value.h

Issue 2659533003: Remove the notificationProvider extension API (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/notifications/notifications_api.cc ('K') | « chrome/test/data/extensions/api_test/notification_provider/test_app/window.html ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_event_histogram_value.h
diff --git a/extensions/browser/extension_event_histogram_value.h b/extensions/browser/extension_event_histogram_value.h
index 31a23a688787bd7d3f3e7574b8524bcc4243ce69..4c19d921cea6e6cf16e103c47f4f54239b7c104e 100644
--- a/extensions/browser/extension_event_histogram_value.h
+++ b/extensions/browser/extension_event_histogram_value.h
@@ -208,9 +208,9 @@ enum HistogramValue {
NETWORKING_PRIVATE_ON_NETWORK_LIST_CHANGED,
NETWORKING_PRIVATE_ON_NETWORKS_CHANGED,
NETWORKING_PRIVATE_ON_PORTAL_DETECTION_COMPLETED,
- NOTIFICATION_PROVIDER_ON_CLEARED,
- NOTIFICATION_PROVIDER_ON_CREATED,
- NOTIFICATION_PROVIDER_ON_UPDATED,
+ NOTIFICATION_PROVIDER_ON_CLEARED, // unused
Devlin 2017/01/28 02:45:03 instead of // unused, prefixed these with DELETED_
Peter Beverloo 2017/02/09 16:03:10 Acknowledged.
+ NOTIFICATION_PROVIDER_ON_CREATED, // unused
+ NOTIFICATION_PROVIDER_ON_UPDATED, // unused
Ilya Sherman 2017/01/26 21:33:41 Sorry, to expand on my previous comment: Please ch
Peter Beverloo 2017/01/27 15:11:22 Done.
NOTIFICATIONS_ON_BUTTON_CLICKED,
NOTIFICATIONS_ON_CLICKED,
NOTIFICATIONS_ON_CLOSED,
« chrome/browser/extensions/api/notifications/notifications_api.cc ('K') | « chrome/test/data/extensions/api_test/notification_provider/test_app/window.html ('k') | extensions/common/permissions/api_permission.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698