Remove the notificationProvider extension API

extensions/browser/extension_event_histogram_value.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_
 #define EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_
 
 namespace extensions {
 namespace events {
 
@@ skipping 190 matching lines @@
   MEDIA_GALLERIES_ON_GALLERY_CHANGED,
   MEDIA_GALLERIES_ON_SCAN_PROGRESS,
   MEDIA_PLAYER_PRIVATE_ON_NEXT_TRACK,
   MEDIA_PLAYER_PRIVATE_ON_PREV_TRACK,
   MEDIA_PLAYER_PRIVATE_ON_TOGGLE_PLAY_STATE,
   NETWORKING_CONFIG_ON_CAPTIVE_PORTAL_DETECTED,
   NETWORKING_PRIVATE_ON_DEVICE_STATE_LIST_CHANGED,
   NETWORKING_PRIVATE_ON_NETWORK_LIST_CHANGED,
   NETWORKING_PRIVATE_ON_NETWORKS_CHANGED,
   NETWORKING_PRIVATE_ON_PORTAL_DETECTION_COMPLETED,
-  NOTIFICATION_PROVIDER_ON_CLEARED,
-  NOTIFICATION_PROVIDER_ON_CREATED,
-  NOTIFICATION_PROVIDER_ON_UPDATED,
+  NOTIFICATION_PROVIDER_ON_CLEARED,  // unused

[Devlin, 2017/01/28 02:45:03]

instead of // unused, prefixed these with DELETED_ (as e.g. line 193 does)

[Peter Beverloo, 2017/02/09 16:03:10]

Acknowledged.

+  NOTIFICATION_PROVIDER_ON_CREATED,  // unused
+  NOTIFICATION_PROVIDER_ON_UPDATED,  // unused

[Ilya Sherman, 2017/01/26 21:33:41]

Sorry, to expand on my previous comment: Please change these names to be
prefixed with "DELETED_" as elsewhere in this file, then run the script
documented below to update histograms.xml.

[Peter Beverloo, 2017/01/27 15:11:22]

Done.

   NOTIFICATIONS_ON_BUTTON_CLICKED,
   NOTIFICATIONS_ON_CLICKED,
   NOTIFICATIONS_ON_CLOSED,
   NOTIFICATIONS_ON_PERMISSION_LEVEL_CHANGED,
   NOTIFICATIONS_ON_SHOW_SETTINGS,
   OMNIBOX_ON_INPUT_CANCELLED,
   OMNIBOX_ON_INPUT_CHANGED,
   OMNIBOX_ON_INPUT_ENTERED,
   OMNIBOX_ON_INPUT_STARTED,
   PAGE_ACTION_ON_CLICKED,
@@ skipping 194 matching lines @@
   BLUETOOTH_LOW_ENERGY_ON_CHARACTERISTIC_READ_REQUEST,
   BLUETOOTH_LOW_ENERGY_ON_CHARACTERISTIC_WRITE_REQUEST,
   BLUETOOTH_LOW_ENERGY_ON_DESCRIPTOR_READ_REQUEST,
   BLUETOOTH_LOW_ENERGY_ON_DESCRIPTOR_WRITE_REQUEST,
   ACCESSIBILITY_PRIVATE_ON_ACCESSIBILITY_GESTURE,
   QUICK_UNLOCK_PRIVATE_ON_ACTIVE_MODES_CHANGED,
   CLIPBOARD_ON_CLIPBOARD_DATA_CHANGED,
   VIRTUAL_KEYBOARD_PRIVATE_ON_KEYBOARD_CLOSED,
   FILE_MANAGER_PRIVATE_ON_APPS_UPDATED,
   // Last entry: Add new entries above, then run:
   // python tools/metrics/histograms/update_extension_histograms.py

[Ilya Sherman, 2017/01/26 21:32:52]

^^^

[Peter Beverloo, 2017/01/27 15:11:22]

Done.

   ENUM_BOUNDARY
 };
 
 }  // namespace events
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_EXTENSION_EVENT_HISTOGRAM_VALUE_H_