GN: Add missing grit targets for ui/resources/.

GN: Add missing grit targets for ui/resources/.

I forgot to add these targets when I added the build file for GN and
they will be needed to fully build ui/base target and friends.

This patch ports only webui_resources to GN build for now, since making
resources a group target does not work yet.

BUG=367592
TEST=None
R=brettw@chromium.org
TBR=ben
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269484

[brettw, 2014-05-02 23:56:06]

lgtm

https://codereview.chromium.org/265953004/diff/1/ui/resources/BUILD.gn
File ui/resources/BUILD.gn (right):

https://codereview.chromium.org/265953004/diff/1/ui/resources/BUILD.gn#newcode23
ui/resources/BUILD.gn:23: grit("webui_resources") {
Can you put this in a new BUILD.gn in the same dir as the grd file?

[tfarina, 2014-05-03 00:01:22]

https://codereview.chromium.org/265953004/diff/1/ui/resources/BUILD.gn
File ui/resources/BUILD.gn (right):

https://codereview.chromium.org/265953004/diff/1/ui/resources/BUILD.gn#newcode23
ui/resources/BUILD.gn:23: grit("webui_resources") {
On 2014/05/02 23:56:06, brettw wrote:
> Can you put this in a new BUILD.gn in the same dir as the grd file?

I can (I will). I just didn't initially because webui_resources is in
ui/resources/ui_resources.gyp, so I want gyp and gn to match.

As the plan is to have the remaining pieces of ui/webui in ui/base/webui. Ben's
idea (I admit I'm not a huge fan of it though).

[tfarina, 2014-05-03 00:45:29]

Brett, do you see how it is possible?

FAILED: g++ -MMD -MF obj/ui/base/cursor/ui_base.cursor_loader_x11.o.d
-DUI_BASE_IMPLEMENTATION -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS
-DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DUSE_MOJO=1
-DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -DCLD_VERSION=2
-DENABLE_MDNS=1 -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PRINTING=1
-DENABLE_FULL_PRINTING=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DTOOLKIT_VIEWS=1
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1
-DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1 -DUSE_NSS=1
-DUSE_X11=1 -DUSE_XI2_MT=2 -D_FILE_OFFSET_BITS=64 -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_GLIBCXX_DEBUG=1
-DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_GETTOPDEVICE
-DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE
-DSK_ENABLE_INST_COUNT=0 -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"
-DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1
-DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT
-DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_SUPPORT_GPU=1 -DSK_USE_POSIX_THREADS
-DU_USING_ICU_NAMESPACE=0 "-I../.." "-Igen" "-I/usr/include/glib-2.0"
"-I/usr/lib/x86_64-linux-gnu/glib-2.0/include" "-I/usr/include/pango-1.0"
"-I/usr/include/cairo" "-I/usr/include/glib-2.0"
"-I/usr/lib/x86_64-linux-gnu/glib-2.0/include" "-I/usr/include/pixman-1"
"-I/usr/include/freetype2" "-I/usr/include/libpng12" "-I../../skia/config"
"-I../../skia/ext" "-I../../third_party/skia/include/config"
"-I../../third_party/skia/include/core"
"-I../../third_party/skia/include/effects"
"-I../../third_party/skia/include/images"
"-I../../third_party/skia/include/lazy"
"-I../../third_party/skia/include/pathops"
"-I../../third_party/skia/include/pdf" "-I../../third_party/skia/include/pipe"
"-I../../third_party/skia/include/ports"
"-I../../third_party/skia/include/utils" "-I../../third_party/skia/src/core"
"-I../../third_party/skia/src/image" "-I../../third_party/skia/src/opts"
"-I../../third_party/skia/src/ports" "-I../../third_party/skia/src/sfnt"
"-I../../third_party/skia/src/utils" "-I../../third_party/skia/src/lazy"
"-I../../third_party/skia/include/gpu" "-I../../third_party/skia/src/gpu"
"-I../../third_party/icu/source/common" "-I../../third_party/icu/source/i18n"
"-Igen/ui/base/strings" "-Igen/ui/base/strings" -fno-strict-aliasing
-fstack-protector --param=ssp-buffer-size=4 -m64 -funwind-tables -fPIC -pipe
-pthread -Wall -Werror -Wsign-compare -Wendif-labels
-Wno-missing-field-initializers -Wno-unused-parameter -fvisibility=hidden -O0
-g2 -fno-exceptions -fno-threadsafe-statics -fvisibility-inlines-hidden
-fno-rtti -c ../../ui/base/cursor/cursor_loader_x11.cc -o
obj/ui/base/cursor/ui_base.cursor_loader_x11.o
../../ui/base/cursor/cursor_loader_x11.cc:12:31: fatal error:
grit/ui_resources.h: No such file or directory

ui_base depends on ui/resources, but -Igen/ui/resources is not included in the
command line ran by ninja.

[tfarina, 2014-05-03 01:04:13]

It is strange, because if I remove the group and change it back to:

grit("resources") { }

it does work.

[tfarina, 2014-05-03 01:11:08]

I'm attaching the generated ninja file, in case it helps debugging.


On Fri, May 2, 2014 at 10:04 PM, <tfarina@chromium.org> wrote:

> It is strange, because if I remove the group and change it back to:
>
> grit("resources") { }
>
> it does work.
>
> https://codereview.chromium.org/265953004/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-05-07 04:37:24]

Brett, I kept ui_resources as a grit target for now, not adding
ui_unscaled_resources.

I added ui/webui/resources/BUILD.gn

[tfarina, 2014-05-10 00:04:19]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-05-10 00:05:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tfarina@chromium.org/265953004/20001

[tfarina, 2014-05-10 02:14:21]

Committed patchset #2 manually as r269484 (presubmit successful).