ui/resources/BUILD.gn - Issue 265953004: GN: Add missing grit targets for ui/resources/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/resources/BUILD.gn

Issue 265953004: GN: Add missing grit targets for ui/resources/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//tools/grit/grit_rule.gni")	5 import("//tools/grit/grit_rule.gni")

6	6

7 grit("resources") {	7 group("resources") {

8 output_name = "ui_resources"	8 deps = [

	9 ":ui_resources",

	10 ":ui_unscaled_resources",

	11 ":webui_resources",

	12 ]

	13 }

	14

	15 grit("ui_resources") {

9 source = "ui_resources.grd"	16 source = "ui_resources.grd"

10 }	17 }

	18

	19 grit("ui_unscaled_resources") {

	20 source = "ui_unscaled_resources.grd"

	21 }

	22

	23 grit("webui_resources") {
	brettw 2014/05/02 23:56:06 Can you put this in a new BUILD.gn in the same dir Can you put this in a new BUILD.gn in the same dir as the grd file? tfarina 2014/05/03 00:01:22 I can (I will). I just didn't initially because we Show quoted text On 2014/05/02 23:56:06, brettw wrote: > Can you put this in a new BUILD.gn in the same dir as the grd file? I can (I will). I just didn't initially because webui_resources is in ui/resources/ui_resources.gyp, so I want gyp and gn to match. As the plan is to have the remaining pieces of ui/webui in ui/base/webui. Ben's idea (I admit I'm not a huge fan of it though).
	24 source = "../webui/resources/webui_resources.grd"

	25 }

OLD	NEW

« no previous file with comments | « no previous file | ui/resources/ui_resources.gyp » ('j') | no next file with comments »