Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 2659483004: ValueSerializer: Promote scheduled exceptions from wasm::ErrorThrower. (Closed)

Created:
3 years, 11 months ago by jbroman
Modified:
3 years, 11 months ago
Reviewers:
Mircea Trofin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ValueSerializer: Promote scheduled exceptions from wasm::ErrorThrower. wasm::ErrorThrower doesn't actually throw exceptions, it just schedules them. As a result, this exception isn't handled properly by code which expects ValueDeserializer to actually throw. For instance, the unit tests use a TryCatch to catch and handle expected exceptions in unit tests. Before this patch, I see local unit test failures because a wasm decode test schedules one, but it isn't caught (and instead causes Context::New to fail at the beginning of the next test). BUG=685713 Review-Url: https://codereview.chromium.org/2659483004 Cr-Commit-Position: refs/heads/master@{#42718} Committed: https://chromium.googlesource.com/v8/v8/+/78c0be52d2d8e608a15b3a9a9192ad6a9ffaf6a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M src/value-serializer.cc View 1 chunk +10 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jbroman
3 years, 11 months ago (2017-01-26 19:49:26 UTC) #7
Mircea Trofin
lgtm
3 years, 11 months ago (2017-01-26 19:56:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659483004/1
3 years, 11 months ago (2017-01-26 22:16:32 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 22:18:36 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/78c0be52d2d8e608a15b3a9a9192ad6a9ff...

Powered by Google App Engine
This is Rietveld 408576698