Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 265943002: Revert of Remove AudioBuffer::set_duration(), instead base on frames. (Closed)

Created:
6 years, 7 months ago by falken
Modified:
6 years, 7 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, wolenetz
Visibility:
Public.

Description

Revert of Remove AudioBuffer::set_duration(), instead base on frames. (https://codereview.chromium.org/261533002/) Reason for revert: This seems to have broken the chromium.webkit WebKit Win x64 Builder bot. Log: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20x64%20Builder/builds/6453 Snippet from log: c:\b\build\slave\webkit-win-latest-rel-x64\build\src\media\base\audio_buffer.cc(16) : error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\webkit-win-latest-rel-x64\build\src\media\base\audio_buffer.cc(16) : warning C4723: potential divide by 0 Original issue's description: > Remove AudioBuffer::set_duration(), instead base on frames. > > wolenetz@ asked on https://codereview.chromium.org/251893002/ why > we allow set_duration() to be called. It used to be required since > AudioBuffers had no concept of sample rate. However, we now attach > a sample rate to every AudioBuffer which allows us to enforce a > valid duration for every buffer. > > This CL also aligns MakeAudioBuffer() to do the same thing with > planar and interleaved data for the sake of easier testing. > > BUG=none > TEST=media_unittests > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267779 TBR=jrummell@chromium.org,dmichael@chromium.org,dalecurtis@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+457 lines, -324 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/audio_buffer.h View 4 chunks +9 lines, -3 lines 0 comments Download
M media/base/audio_buffer.cc View 10 chunks +31 lines, -19 lines 0 comments Download
M media/base/audio_buffer_converter.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/audio_buffer_converter_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_buffer_queue_unittest.cc View 16 chunks +121 lines, -101 lines 0 comments Download
M media/base/audio_buffer_unittest.cc View 15 chunks +176 lines, -130 lines 0 comments Download
M media/base/audio_discard_helper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/base/audio_discard_helper_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/audio_splicer.cc View 4 chunks +26 lines, -7 lines 0 comments Download
M media/base/audio_splicer_unittest.cc View 5 chunks +17 lines, -18 lines 0 comments Download
M media/base/test_helpers.h View 1 chunk +26 lines, -17 lines 0 comments Download
M media/base/test_helpers.cc View 3 chunks +30 lines, -25 lines 0 comments Download
M media/filters/audio_renderer_algorithm_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M media/filters/audio_renderer_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/decrypting_audio_decoder.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M media/filters/decrypting_audio_decoder_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M media/filters/ffmpeg_audio_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
falken
Created Revert of Remove AudioBuffer::set_duration(), instead base on frames.
6 years, 7 months ago (2014-05-02 10:50:30 UTC) #1
falken
The CQ bit was checked by falken@chromium.org
6 years, 7 months ago (2014-05-02 10:51:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/falken@chromium.org/265943002/1
6 years, 7 months ago (2014-05-02 10:51:26 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 10:52:26 UTC) #4
Message was sent while issue was closed.
Change committed as 267788

Powered by Google App Engine
This is Rietveld 408576698