Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: media/base/audio_buffer.cc

Issue 265943002: Revert of Remove AudioBuffer::set_duration(), instead base on frames. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/audio_buffer.h ('k') | media/base/audio_buffer_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/audio_buffer.cc
diff --git a/media/base/audio_buffer.cc b/media/base/audio_buffer.cc
index 25e8dbe1a1b77a42fef7211dae2710a78c08b486..4b972b90a1abda47c363b0cd46c7c8362ca60ee2 100644
--- a/media/base/audio_buffer.cc
+++ b/media/base/audio_buffer.cc
@@ -10,11 +10,6 @@
#include "media/base/limits.h"
namespace media {
-
-static base::TimeDelta CalculateDuration(int frames, double sample_rate) {
- return base::TimeDelta::FromMicroseconds(
- frames * base::Time::kMicrosecondsPerSecond / sample_rate);
-}
AudioBuffer::AudioBuffer(SampleFormat sample_format,
ChannelLayout channel_layout,
@@ -23,7 +18,8 @@
int frame_count,
bool create_buffer,
const uint8* const* data,
- const base::TimeDelta timestamp)
+ const base::TimeDelta timestamp,
+ const base::TimeDelta duration)
: sample_format_(sample_format),
channel_layout_(channel_layout),
channel_count_(channel_count),
@@ -32,7 +28,7 @@
trim_start_(0),
end_of_stream_(!create_buffer && data == NULL && frame_count == 0),
timestamp_(timestamp),
- duration_(CalculateDuration(adjusted_frame_count_, sample_rate_)) {
+ duration_(duration) {
CHECK_GE(channel_count_, 0);
CHECK_LE(channel_count_, limits::kMaxChannels);
CHECK_GE(frame_count, 0);
@@ -95,7 +91,8 @@
int sample_rate,
int frame_count,
const uint8* const* data,
- const base::TimeDelta timestamp) {
+ const base::TimeDelta timestamp,
+ const base::TimeDelta duration) {
// If you hit this CHECK you likely have a bug in a demuxer. Go fix it.
CHECK_GT(frame_count, 0); // Otherwise looks like an EOF buffer.
CHECK(data[0]);
@@ -106,7 +103,8 @@
frame_count,
true,
data,
- timestamp));
+ timestamp,
+ duration));
}
// static
@@ -124,6 +122,7 @@
frame_count,
true,
NULL,
+ kNoTimestamp(),
kNoTimestamp()));
}
@@ -133,7 +132,8 @@
int channel_count,
int sample_rate,
int frame_count,
- const base::TimeDelta timestamp) {
+ const base::TimeDelta timestamp,
+ const base::TimeDelta duration) {
CHECK_GT(frame_count, 0); // Otherwise looks like an EOF buffer.
// Since data == NULL, format doesn't matter.
return make_scoped_refptr(new AudioBuffer(kSampleFormatF32,
@@ -143,7 +143,8 @@
frame_count,
false,
NULL,
- timestamp));
+ timestamp,
+ duration));
}
// static
@@ -155,6 +156,7 @@
0,
false,
NULL,
+ kNoTimestamp(),
kNoTimestamp()));
}
@@ -244,23 +246,33 @@
CHECK_GE(frames_to_trim, 0);
CHECK_LE(frames_to_trim, adjusted_frame_count_);
- // Adjust the number of frames in this buffer and where the start really is.
+ // Adjust timestamp_ and duration_ to reflect the smaller number of frames.
+ double offset = static_cast<double>(duration_.InMicroseconds()) *
+ frames_to_trim / adjusted_frame_count_;
+ base::TimeDelta offset_as_time =
+ base::TimeDelta::FromMicroseconds(static_cast<int64>(offset));
+ timestamp_ += offset_as_time;
+ duration_ -= offset_as_time;
+
+ // Finally adjust the number of frames in this buffer and where the start
+ // really is.
adjusted_frame_count_ -= frames_to_trim;
trim_start_ += frames_to_trim;
-
- // Adjust timestamp_ and duration_ to reflect the smaller number of frames.
- const base::TimeDelta old_duration = duration_;
- duration_ = CalculateDuration(adjusted_frame_count_, sample_rate_);
- timestamp_ += old_duration - duration_;
}
void AudioBuffer::TrimEnd(int frames_to_trim) {
CHECK_GE(frames_to_trim, 0);
CHECK_LE(frames_to_trim, adjusted_frame_count_);
- // Adjust the number of frames and duration for this buffer.
+ // Adjust duration_ only to reflect the smaller number of frames.
+ double offset = static_cast<double>(duration_.InMicroseconds()) *
+ frames_to_trim / adjusted_frame_count_;
+ base::TimeDelta offset_as_time =
+ base::TimeDelta::FromMicroseconds(static_cast<int64>(offset));
+ duration_ -= offset_as_time;
+
+ // Finally adjust the number of frames in this buffer.
adjusted_frame_count_ -= frames_to_trim;
- duration_ = CalculateDuration(adjusted_frame_count_, sample_rate_);
}
} // namespace media
« no previous file with comments | « media/base/audio_buffer.h ('k') | media/base/audio_buffer_converter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698