Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2659413002: PPC/s390: [TypeFeedbackVector] Combine the literals array and the feedback vector. (Closed)

Created:
3 years, 10 months ago by JaideepBajwa
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [TypeFeedbackVector] Combine the literals array and the feedback vector. Port 93f05b64ae1c1f8e010467331de1bf02d800dede Original Commit Message: They have the same lifetime. It's a match! Both structures are native context dependent and dealt with (creation, clearing, gathering feedback) at the same time. By treating the spaces used for literal boilerplates as feedback vector slots, we no longer have to keep track of the materialized literal count elsewhere. A follow-on CL removes even more parser infrastructure related to this count. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG=v8:5456 LOG=N Review-Url: https://codereview.chromium.org/2659413002 Cr-Commit-Position: refs/heads/master@{#42778} Committed: https://chromium.googlesource.com/v8/v8/+/626b95e37e58d10e9f504a645163c173b938fd21

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M src/builtins/ppc/builtins-ppc.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/builtins/s390/builtins-s390.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JaideepBajwa
ptal
3 years, 10 months ago (2017-01-30 15:01:42 UTC) #1
john.yan
lgtm
3 years, 10 months ago (2017-01-30 15:05:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2659413002/1
3 years, 10 months ago (2017-01-30 15:06:07 UTC) #4
commit-bot: I haz the power
3 years, 10 months ago (2017-01-30 15:26:00 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/626b95e37e58d10e9f504a645163c173b93...

Powered by Google App Engine
This is Rietveld 408576698