Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: sync/notifier/sync_invalidation_listener.cc

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: merge (see prior patch for try jobs) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/notifier/sync_invalidation_listener.cc
diff --git a/sync/notifier/sync_invalidation_listener.cc b/sync/notifier/sync_invalidation_listener.cc
index 71be3ecad69b21f6ab265f1e88c3349995483a14..763cc876bf0e954ca1e8a28c6f78c707215ce4ea 100644
--- a/sync/notifier/sync_invalidation_listener.cc
+++ b/sync/notifier/sync_invalidation_listener.cc
@@ -33,13 +33,13 @@ SyncInvalidationListener::Delegate::~Delegate() {}
SyncInvalidationListener::SyncInvalidationListener(
base::TickClock* tick_clock,
scoped_ptr<notifier::PushClient> push_client)
- : weak_ptr_factory_(this),
- ack_tracker_(tick_clock, this),
+ : ack_tracker_(tick_clock, this),
push_client_(push_client.get()),
sync_system_resources_(push_client.Pass(), this),
delegate_(NULL),
ticl_state_(DEFAULT_INVALIDATION_ERROR),
- push_client_state_(DEFAULT_INVALIDATION_ERROR) {
+ push_client_state_(DEFAULT_INVALIDATION_ERROR),
+ weak_ptr_factory_(this) {
DCHECK(CalledOnValidThread());
push_client_->AddObserver(this);
}

Powered by Google App Engine
This is Rietveld 408576698