Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: sync/notifier/non_blocking_invalidator.cc

Issue 26594002: Chrome sync: Put WeakPtrFactory members at the end (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/notifier/non_blocking_invalidator.h ('k') | sync/notifier/sync_invalidation_listener.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/notifier/non_blocking_invalidator.cc
diff --git a/sync/notifier/non_blocking_invalidator.cc b/sync/notifier/non_blocking_invalidator.cc
index d4c602b4e45e223b6cc8f9c99eb5d0161205efa9..a6669be9a5aca11e22f5d2f2e1883ceef6ccdc93 100644
--- a/sync/notifier/non_blocking_invalidator.cc
+++ b/sync/notifier/non_blocking_invalidator.cc
@@ -141,13 +141,12 @@ NonBlockingInvalidator::NonBlockingInvalidator(
const WeakHandle<InvalidationStateTracker>&
invalidation_state_tracker,
const std::string& client_info)
- : weak_ptr_factory_(this),
- core_(
- new Core(MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()))),
- parent_task_runner_(
- base::ThreadTaskRunnerHandle::Get()),
- network_task_runner_(notifier_options.request_context_getter->
- GetNetworkTaskRunner()) {
+ : parent_task_runner_(base::ThreadTaskRunnerHandle::Get()),
+ network_task_runner_(notifier_options.request_context_getter->
akalin 2013/10/08 22:26:04 break after (?
dmichael (off chromium) 2013/10/08 22:41:19 Done.
+ GetNetworkTaskRunner()),
+ weak_ptr_factory_(this) {
+ core_ = new Core(MakeWeakHandle(weak_ptr_factory_.GetWeakPtr()));
+
if (!network_task_runner_->PostTask(
FROM_HERE,
base::Bind(
« no previous file with comments | « sync/notifier/non_blocking_invalidator.h ('k') | sync/notifier/sync_invalidation_listener.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698