Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Issue 2659373002: Partial merge of https://crrev.com/b8e1ac73c904f3134c4be5fd978ef46de1b95279. (Closed)

Created:
3 years, 10 months ago by pastarmovj
Modified:
3 years, 10 months ago
Reviewers:
bustamante
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Partial merge of https://crrev.com/b8e1ac73c904f3134c4be5fd978ef46de1b95279. Remove the enable/disable links for the about:plugins page. The partial merge only removes the links without touching the underlying code to avoid merge conflicts due to dependency on another CL. Effectively the result is the same. BUG=615738, 673199 TEST=manual CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation R=bustamante@chromium.org TBR=bauerb Review-Url: https://codereview.chromium.org/2659373002 . Cr-Commit-Position: refs/branch-heads/2924@{#888} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/fdacdd761288cc4be81ae5cecdda88413e36d106

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -36 lines) Patch
M chrome/browser/resources/plugins.css View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/plugins.html View 2 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
pastarmovj
Hi Richard, this is a partial merge of the CL requested in crbug.com/673199 . I ...
3 years, 10 months ago (2017-01-30 14:07:14 UTC) #3
bustamante
lgtm Thanks for putting this together!
3 years, 10 months ago (2017-01-30 16:58:47 UTC) #4
pastarmovj
3 years, 10 months ago (2017-01-31 07:21:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fdacdd761288cc4be81ae5cecdda88413e36d106 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698