Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2659353003: Remove refine icon from multi-PW suggestions (Closed)

Created:
3 years, 10 months ago by Ted C
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Remove refine icon from multi-PW suggestions Currently, when a user is given a Physical Web overflow suggestion in the omnibox, a refine icon is also displayed. Tapping the refine icon will fill the omnibox with several titles rather than a URL. This change removes the refine icon in that condition. BUG=663842 Review-Url: https://codereview.chromium.org/2653753009 Cr-Commit-Position: refs/heads/master@{#446463} (cherry picked from commit c9c42e9c5a72a3ac28d698e848fba2888a32e00f) Review-Url: https://codereview.chromium.org/2659353003 . Cr-Commit-Position: refs/branch-heads/2987@{#185} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/e3c9b8734cb9d06d1b9525769ede1ec2287c5ea1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Ted C
3 years, 10 months ago (2017-01-30 21:05:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e3c9b8734cb9d06d1b9525769ede1ec2287c5ea1.

Powered by Google App Engine
This is Rietveld 408576698