Convert CSSPrimitiveValueUnits.in to json5 format

Convert last CSSPrimitiveValueUnits.in to json5 format

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Update make_cssom_types.py to use json5_generator
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG=677884
Review-Url: https://codereview.chromium.org/2659283002
Cr-Commit-Position: refs/heads/master@{#449571}
Committed: https://chromium.googlesource.com/chromium/src/+/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d

[ktyliu, 2017-01-29 22:01:42]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 22:01:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 23:35:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 23:35:17]

Dry run: This issue passed the CQ dry run.

[ktyliu, 2017-02-09 21:51:08]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:51:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-02-09 21:51:45]

Description was changed from

==========
Convert CSSPrimitiveValueUnits.in to json5 format

BUG=677884
==========

to

==========
Convert last .in to json5 format and remove in_file&in_generator

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Remove in_file(_unittest).py and in_generator.py
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG=677884
==========

[ktyliu, 2017-02-09 21:53:04]

The CQ bit was unchecked by ktyliu@chromium.org

[ktyliu, 2017-02-09 21:56:22]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 21:57:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-02-09 22:24:27]

The CQ bit was unchecked by ktyliu@chromium.org

[ktyliu, 2017-02-09 22:32:00]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[ktyliu, 2017-02-09 22:32:09]

The CQ bit was unchecked by ktyliu@chromium.org

[ktyliu, 2017-02-09 22:32:40]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 22:33:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ktyliu, 2017-02-09 22:33:45]

Description was changed from

==========
Convert last .in to json5 format and remove in_file&in_generator

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Remove in_file(_unittest).py and in_generator.py
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG=677884
==========

to

==========
Convert last CSSPrimitiveValueUnits.in to json5 format

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Update make_cssom_types.py to use json5_generator
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG=677884
==========

[ktyliu, 2017-02-09 22:42:44]

ktyliu@chromium.org changed reviewers:
+ sashab@chromium.org

[ktyliu, 2017-02-09 22:42:45]

Hi Sasha,

This is the last .in file and we're all done! \o/

Note I didn't delete in_generator.py here since that's still used in two scripts
that don't take .in files as input, but just uses small part of in_generator
that processes command line arguments:
- build/scripts/minimize_css.py (takes a .css as input)
- build/scripts/make_css_tokenizer_codepoints.py (has all the data within the
script)

[commit-bot: I haz the power, 2017-02-10 00:34:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 00:34:17]

Dry run: This issue passed the CQ dry run.

[sashab, 2017-02-10 01:20:17]

I can't believe it~!!! \o/ \o/ \o/

Hmm, sucks we can't remove the in genreator. Can you add a big comment to the
top of in_generator.py saying "this is now deprecated - use json5_generator.py
instead"

YAYYY GO KEVIN~~!!! WOOOO

+meade, +dpranke, +alancutter and +chrishall to celebrate

LGTM

https://codereview.chromium.org/2659283002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.json5 (right):

https://codereview.chromium.org/2659283002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.json5:5: unit_type:
{},
default: None (from py file)

[ktyliu, 2017-02-10 02:13:32]

good suggestion to put deprecation notice, done :)

we should be able to modify those two scripts so we don't need in_file and
in_generator any more; can do that in a follow up CL

https://codereview.chromium.org/2659283002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.json5 (right):

https://codereview.chromium.org/2659283002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.json5:5: unit_type:
{},
On 2017/02/10 at 01:20:17, sashab wrote:
> default: None (from py file)

default of None is actually the implied default behavior so it's not needed

note it's not "default: None" since None is not a valid JSON5/JavaScript keyword
-- a native json5 parser will fail to parse "None"; the correct JSON5 equivalent
is "null" but I'll need to update json5_generator to support it

[ktyliu, 2017-02-10 02:13:43]

The CQ bit was checked by ktyliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 02:14:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-02-10 02:15:46]

Still LGTM, and would love that follow up patch -- too cool :D

[ktyliu, 2017-02-10 02:19:11]

The CQ bit was unchecked by ktyliu@chromium.org

[ktyliu, 2017-02-10 02:19:13]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:19:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 02:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 02:27:55]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sashab, 2017-02-10 02:29:20]

Need a platform/ RS. :)

[ktyliu, 2017-02-10 02:31:47]

ktyliu@chromium.org changed reviewers:
+ haraken@chromium.org

[ktyliu, 2017-02-10 02:31:47]

Hi Kentaro,

Can you help RSLGTM the change to third_party/WebKit/Source/platform/BUILD.gn ?

Thanks,
Kevin

[Dirk Pranke, 2017-02-10 02:36:01]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2017-02-10 02:36:01]

lgtm

[haraken, 2017-02-10 02:37:36]

LGTM

[ktyliu, 2017-02-10 02:38:16]

The CQ bit was checked by ktyliu@chromium.org

[ktyliu, 2017-02-10 02:38:33]

On 2017/02/10 at 02:37:36, haraken wrote:
> LGTM

thanks much for the quick approval

[commit-bot: I haz the power, 2017-02-10 02:38:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-02-10 02:44:35]

dglazkov@chromium.org changed reviewers:
+ dglazkov@chromium.org

[dglazkov, 2017-02-10 02:44:36]

lgtm

[commit-bot: I haz the power, 2017-02-10 08:15:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 08:15:23]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ktyliu, 2017-02-10 08:18:00]

The CQ bit was checked by ktyliu@chromium.org

[commit-bot: I haz the power, 2017-02-10 08:18:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 09:28:12]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486714680668090,
"parent_rev": "1fe4b50ee936e74cf7f9428dc17555574ae67f43", "commit_rev":
"1e03a5fea4e8dad12f91457dd2240fd0025cfd8d"}

[commit-bot: I haz the power, 2017-02-10 09:29:13]

Description was changed from

==========
Convert last CSSPrimitiveValueUnits.in to json5 format

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Update make_cssom_types.py to use json5_generator
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG=677884
==========

to

==========
Convert last CSSPrimitiveValueUnits.in to json5 format

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Update make_cssom_types.py to use json5_generator
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG=677884

Review-Url: https://codereview.chromium.org/2659283002
Cr-Commit-Position: refs/heads/master@{#449571}
Committed:
https://chromium.googlesource.com/chromium/src/+/1e03a5fea4e8dad12f91457dd224...
==========

[commit-bot: I haz the power, 2017-02-10 09:29:14]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/1e03a5fea4e8dad12f91457dd224...