Move keyboard related files from core/ to platform.

Move keyboard related files from core/ to platform.

BUG=297477
TEST=None, trivial move.
R=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159547

[abarth-chromium, 2013-10-13 15:13:18]

https://codereview.chromium.org/26592011/diff/1/Source/platform/blink_platfor...
File Source/platform/blink_platform.gyp (right):

https://codereview.chromium.org/26592011/diff/1/Source/platform/blink_platfor...
Source/platform/blink_platform.gyp:144: ['exclude',
'platform/chromium/KeyCodeConversionGtk\\.cpp$'],
> Cannot open include file: 'gdk/gdkkeysyms.h': No such file or directory

This should probably be:

['exclude', 'Gtk\\.cpp$'],

[abarth-chromium, 2013-10-13 15:14:51]

https://codereview.chromium.org/26592011/diff/1/Source/platform/KeyCodeConver...
File Source/platform/KeyCodeConversion.h (right):

https://codereview.chromium.org/26592011/diff/1/Source/platform/KeyCodeConver...
Source/platform/KeyCodeConversion.h:36: int windowsKeyCodeForKeyEvent(unsigned
keycode);
You're going to need to add PLATFORM_EXPORT here.  (You can include
platform/PlatformExport.h to get the declaration.)

Also, please remove the intent here.  Code inside namespaces shouldn't be
indented.

[tfarina, 2013-10-13 16:52:26]

https://codereview.chromium.org/26592011/diff/1/Source/platform/KeyCodeConver...
File Source/platform/KeyCodeConversion.h (right):

https://codereview.chromium.org/26592011/diff/1/Source/platform/KeyCodeConver...
Source/platform/KeyCodeConversion.h:36: int windowsKeyCodeForKeyEvent(unsigned
keycode);
On 2013/10/13 15:14:51, abarth wrote:
> You're going to need to add PLATFORM_EXPORT here.  (You can include
> platform/PlatformExport.h to get the declaration.)
> 
> Also, please remove the intent here.  Code inside namespaces shouldn't be
> indented.

Done.

https://codereview.chromium.org/26592011/diff/1/Source/platform/blink_platfor...
File Source/platform/blink_platform.gyp (right):

https://codereview.chromium.org/26592011/diff/1/Source/platform/blink_platfor...
Source/platform/blink_platform.gyp:144: ['exclude',
'platform/chromium/KeyCodeConversionGtk\\.cpp$'],
On 2013/10/13 15:13:19, abarth wrote:
> > Cannot open include file: 'gdk/gdkkeysyms.h': No such file or directory
> 
> This should probably be:
> 
> ['exclude', 'Gtk\\.cpp$'],

Done.

[abarth-chromium, 2013-10-13 17:42:21]

LGTM

https://codereview.chromium.org/26592011/diff/9001/Source/platform/KeyboardCo...
File Source/platform/KeyboardCodes.h (right):

https://codereview.chromium.org/26592011/diff/9001/Source/platform/KeyboardCo...
Source/platform/KeyboardCodes.h:42: enum {
Please fix the indent in these files too.

[tfarina, 2013-10-13 17:56:33]

https://codereview.chromium.org/26592011/diff/9001/Source/platform/KeyboardCo...
File Source/platform/KeyboardCodes.h (right):

https://codereview.chromium.org/26592011/diff/9001/Source/platform/KeyboardCo...
Source/platform/KeyboardCodes.h:42: enum {
On 2013/10/13 17:42:26, abarth wrote:
> Please fix the indent in these files too.

Done.

[commit-bot: I haz the power, 2013-10-13 17:56:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/26592011/17001

[commit-bot: I haz the power, 2013-10-13 17:57:03]

Failed to apply patch for Source/platform/blink_platform.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/platform/blink_platform.gypi
  Hunk #3 FAILED at 74.
  1 out of 3 hunks FAILED -- saving rejects to file
Source/platform/blink_platform.gypi.rej

Patch:       Source/platform/blink_platform.gypi
Index: Source/platform/blink_platform.gypi
diff --git a/Source/platform/blink_platform.gypi
b/Source/platform/blink_platform.gypi
index
01fbf386230bd1abc289a17e3bff43bdb99e7efc..0407e05e59d61483ed2151bd494c282e20916c8d
100644
--- a/Source/platform/blink_platform.gypi
+++ b/Source/platform/blink_platform.gypi
@@ -20,6 +20,10 @@
       'HostWindow.h',
       'JSONValues.cpp',
       'JSONValues.h',
+      'KeyCodeConversion.h',
+      'KeyCodeConversionAndroid.cpp',
+      'KeyCodeConversionGtk.cpp',
+      'KeyboardCodes.h',
       'Language.cpp',
       'Language.h',
       'LayoutTestSupport.cpp',
@@ -53,10 +57,10 @@
       'PlatformWheelEvent.h',
       'PurgeableBuffer.cpp',
       'PurgeableBuffer.h',
-      'SecureTextInput.cpp',
-      'SecureTextInput.h',
       'SSLKeyGenerator.cpp',
       'SSLKeyGenerator.h',
+      'SecureTextInput.cpp',
+      'SecureTextInput.h',
       'SharedBuffer.cpp',
       'SharedBuffer.h',
       'SharedBufferChunkReader.cpp',
@@ -70,12 +74,13 @@
       'Timer.cpp',
       'Timer.h',
       'TraceEvent.h',
-      'UserGestureIndicator.cpp',
-      'UserGestureIndicator.h',
       'URLPatternMatcher.cpp',
       'URLPatternMatcher.h',
       'UUID.cpp',
       'UUID.h',
+      'UserGestureIndicator.cpp',
+      'UserGestureIndicator.h',
+      'WindowsKeyboardCodes.h',
       'animation/UnitBezier.h',
       'audio/AudioArray.h',
       'audio/AudioBus.cpp',

[commit-bot: I haz the power, 2013-10-13 18:07:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/26592011/23001

[commit-bot: I haz the power, 2013-10-13 18:56:58]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-13 20:08:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/26592011/23001

[commit-bot: I haz the power, 2013-10-13 21:38:34]

Retried try job too often on win_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_...

[commit-bot: I haz the power, 2013-10-13 21:58:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/26592011/23001

[commit-bot: I haz the power, 2013-10-13 22:27:19]

Change committed as 159547