Source/platform/KeyCodeConversion.h - Issue 26592011: Move keyboard related files from core/ to platform.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/platform/KeyCodeConversion.h

Issue 26592011: Move keyboard related files from core/ to platform. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/core/platform/chromium/KeyboardCodes.h ('k') | Source/platform/KeyCodeConversionAndroid.cpp » ('j') | Source/platform/blink_platform.gyp » ('J')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.	2 * Copyright (c) 2008, 2009, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 15 matching lines...) Expand all Loading...
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT	26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT

27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE	27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE

28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.	28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

29 */	29 */

30	30

31 #ifndef KeyCodeConversion_h	31 #ifndef KeyCodeConversion_h

32 #define KeyCodeConversion_h	32 #define KeyCodeConversion_h

33	33

34 namespace WebCore {	34 namespace WebCore {

35	35

36 int windowsKeyCodeForKeyEvent(unsigned keycode);	36 int windowsKeyCodeForKeyEvent(unsigned keycode);
	abarth-chromium 2013/10/13 15:14:51 You're going to need to add PLATFORM_EXPORT here. You're going to need to add PLATFORM_EXPORT here. (You can include platform/PlatformExport.h to get the declaration.) Also, please remove the intent here. Code inside namespaces shouldn't be indented. tfarina 2013/10/13 16:52:26 Done. Show quoted text On 2013/10/13 15:14:51, abarth wrote: > You're going to need to add PLATFORM_EXPORT here. (You can include > platform/PlatformExport.h to get the declaration.) > > Also, please remove the intent here. Code inside namespaces shouldn't be > indented. Done.
37	37

38 } // namespace WebCore	38 } // namespace WebCore

39	39

40 #endif	40 #endif

OLD	NEW