Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: buildbot/slave/skia_slave_scripts/run_bench.py

Issue 26592010: Changes bench to output with git hash filename; cleans up bench_graph_svg to only handle bench aler… (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/slave/skia_slave_scripts/check_for_regressions.py ('k') | trunk/bench/bench_graph_svg.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/slave/skia_slave_scripts/run_bench.py
===================================================================
--- buildbot/slave/skia_slave_scripts/run_bench.py (revision 11761)
+++ buildbot/slave/skia_slave_scripts/run_bench.py (working copy)
@@ -24,17 +24,6 @@
return ['--timers', 'wcg', '--logFile', data_file]
-def GetSvnRevision(commit_hash):
- output = shell_utils.Bash([GIT, 'show', '-s', commit_hash],
- echo=False, log_in_real_time=False)
- results = re.findall(GIT_SVN_ID_MATCH_STR, output)
- if results:
- return results[0]
- else:
- raise Exception('No git-svn-id found for %s\nOutput:\n%s' % (commit_hash,
- output))
-
-
class RunBench(BuildStep):
def __init__(self, timeout=9600, no_output_timeout=9600, **kwargs):
super(RunBench, self).__init__(timeout=timeout,
@@ -43,7 +32,7 @@
def _BuildDataFile(self):
return os.path.join(self._device_dirs.PerfDir(),
- 'bench_r%s_data' % GetSvnRevision(self._got_revision))
+ 'bench_%s_data' % self._got_revision)
def _Run(self):
args = ['-i', self._device_dirs.ResourceDir()]
« no previous file with comments | « buildbot/slave/skia_slave_scripts/check_for_regressions.py ('k') | trunk/bench/bench_graph_svg.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698