Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: buildbot/slave/skia_slave_scripts/check_for_regressions.py

Issue 26592010: Changes bench to output with git hash filename; cleans up bench_graph_svg to only handle bench aler… (Closed) Base URL: http://skia.googlecode.com/svn/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « buildbot/slave/skia_slave_scripts/bench_pictures.py ('k') | buildbot/slave/skia_slave_scripts/run_bench.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/slave/skia_slave_scripts/check_for_regressions.py
===================================================================
--- buildbot/slave/skia_slave_scripts/check_for_regressions.py (revision 11761)
+++ buildbot/slave/skia_slave_scripts/check_for_regressions.py (working copy)
@@ -20,23 +20,20 @@
**kwargs)
def _RunInternal(self, representation):
- path_to_bench_graph_svg = os.path.join('bench', 'bench_graph_svg.py')
+ path_to_check_bench_regressions = os.path.join('bench',
+ 'check_bench_regressions.py')
path_to_bench_expectations = os.path.join('bench',
'bench_expectations_%s.txt' % self._builder_name)
if not os.path.isfile(path_to_bench_expectations):
print 'Skip due to missing expectations: %s' % path_to_bench_expectations
return
- graph_title = 'Bench_Performance_for_%s' % self._builder_name
- cmd = ['python', path_to_bench_graph_svg,
+ cmd = ['python', path_to_check_bench_regressions,
+ '-a', representation,
+ '-b', self._builder_name,
'-d', self._perf_data_dir,
'-e', path_to_bench_expectations,
- '-r', '-1',
- '-f', '-1',
- '-l', graph_title,
- '-m', representation,
+ '-r', self._got_revision,
]
- if self._builder_name.find('_Win') >= 0:
- cmd.extend(['-i', 'c']) # Ignore cpu time for Windows.
shell_utils.Bash(cmd)
« no previous file with comments | « buildbot/slave/skia_slave_scripts/bench_pictures.py ('k') | buildbot/slave/skia_slave_scripts/run_bench.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698